Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let PPanGGOLIN keep running if partition step fails #270

Open
JeanMainguy opened this issue Aug 21, 2024 · 0 comments
Open

Let PPanGGOLIN keep running if partition step fails #270

JeanMainguy opened this issue Aug 21, 2024 · 0 comments

Comments

@JeanMainguy
Copy link
Member

JeanMainguy commented Aug 21, 2024

It would be great if PPanGGOLIN could continue running even when the partition step fails, as it can still deliver valuable data like core and soft genomes. Originally, this scenario was handled by assigning data to the "unknown" partition, but this functionality has since been removed.

Right now, PPanGGOLIN prints a log if partitioning fails (a warning log since PR #269). If partitions completely failed, the pipeline fails latter with error reported in issue #262.

Improving this so it can keep going without crashing would make it more robust and useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant