Skip to content

Commit 3d1cbf6

Browse files
feature(main): using 22 default port (#3759) (#3760)
Signed-off-by: cuisongliu <[email protected]> Co-authored-by: cuisongliu <[email protected]>
1 parent 5f62b0c commit 3d1cbf6

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

pkg/apply/run.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func (r *ClusterArgs) runArgs(cmd *cobra.Command, args *RunArgs, imageList []str
117117

118118
r.cluster.SetNewImages(imageList)
119119

120-
defaultPort := strconv.Itoa(int(r.cluster.Spec.SSH.Port))
120+
defaultPort := strconv.Itoa(int(defaultSSHPort(r.cluster.Spec.SSH.Port)))
121121
masters := stringsutil.SplitRemoveEmpty(args.Cluster.Masters, ",")
122122
nodes := stringsutil.SplitRemoveEmpty(args.Cluster.Nodes, ",")
123123
r.hosts = []v2.Host{}
@@ -139,10 +139,11 @@ func (r *ClusterArgs) runArgs(cmd *cobra.Command, args *RunArgs, imageList []str
139139
}
140140

141141
func (r *ClusterArgs) setHostWithIpsPort(ips []string, roles []string) {
142-
defaultPort := strconv.Itoa(int(r.cluster.Spec.SSH.Port))
142+
defaultPort := strconv.Itoa(int(defaultSSHPort(r.cluster.Spec.SSH.Port)))
143143
hostMap := map[string]*v2.Host{}
144144
for i := range ips {
145145
ip, port := iputils.GetHostIPAndPortOrDefault(ips[i], defaultPort)
146+
logger.Debug("defaultPort: %s", defaultPort)
146147
socket := fmt.Sprintf("%s:%s", ip, port)
147148
if stringsutil.In(socket, r.cluster.GetAllIPS()) {
148149
continue
@@ -163,3 +164,10 @@ func (r *ClusterArgs) setHostWithIpsPort(ips []string, roles []string) {
163164
r.hosts = append(r.hosts, *host)
164165
}
165166
}
167+
168+
func defaultSSHPort(port uint16) uint16 {
169+
if port == 0 {
170+
port = v2.DefaultSSHPort
171+
}
172+
return port
173+
}

pkg/apply/run_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func TestNewApplierFromArgs(t *testing.T) {
167167
},
168168
Spec: v2.ClusterSpec{
169169
Hosts: []v2.Host{
170-
{IPS: []string{iputils.LocalIP(addr) + ":0"}, Roles: []string{v2.MASTER, GetHostArch(ssh.NewSSHClient(&v2.SSH{}, true), iputils.LocalIP(addr)+":0")}},
170+
{IPS: []string{iputils.LocalIP(addr) + ":22"}, Roles: []string{v2.MASTER, GetHostArch(ssh.NewSSHClient(&v2.SSH{}, true), iputils.LocalIP(addr)+":22")}},
171171
},
172172
Image: []string{"labring/kubernetes:v1.24.0"},
173173
SSH: v2.SSH{},

pkg/apply/utils.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,7 @@ func GetNewImages(currentCluster, desiredCluster *v2.Cluster) []string {
141141
}
142142

143143
func CheckAndInitialize(cluster *v2.Cluster) {
144-
if cluster.Spec.SSH.Port == 0 {
145-
cluster.Spec.SSH.Port = v2.DefaultSSHPort
146-
}
144+
cluster.Spec.SSH.Port = defaultSSHPort(cluster.Spec.SSH.Port)
147145

148146
if cluster.Spec.SSH.Pk == "" {
149147
cluster.Spec.SSH.Pk = filepath.Join(constants.GetHomeDir(), ".ssh", "id_rsa")

0 commit comments

Comments
 (0)