fix get user id without cache (#5635)

Author: bxy4543

controllers/account/controllers/payment_controller.go

@@ -295,7 +295,7 @@ func (r *PaymentReconciler) reconcileNewPayment(payment *accountv1.Payment) erro
 			return fmt.Errorf("user ID is empty")
 		}
 		payment.Spec.UserCR = payment.Spec.UserID
-		id, err := r.Account.AccountV2.GetUserID(&pkgtypes.UserQueryOpts{Owner: payment.Spec.UserCR})
+		id, err := r.Account.AccountV2.GetUserID(&pkgtypes.UserQueryOpts{Owner: payment.Spec.UserCR, WithOutCache: true})
 		if err != nil {
 			return fmt.Errorf("get user ID failed: %w", err)
 		}

controllers/pkg/database/cockroach/accountv2.go

@@ -438,8 +438,8 @@ func (c *Cockroach) GetUserID(ops *types.UserQueryOpts) (id string, err error) {
 		return "", fmt.Errorf("empty query opts")
 	}
 	if ops.Owner != "" {
-		id, err = c.getUserIDByOwner(ops.Owner)
-		if ops.IgnoreEmpty && err == gorm.ErrRecordNotFound {
+		id, err = c.getUserIDByOwner(ops.Owner, !ops.WithOutCache)
+		if ops.IgnoreEmpty && errors.Is(err, gorm.ErrRecordNotFound) {
 			return "", nil
 		}
 		return id, err
@@ -481,6 +481,15 @@ func (c *Cockroach) getUserUIDByOwnerWithCache(owner string) (uuid.UUID, error)
 	if v, ok := c.ownerUsrUIDMap.Load(owner); ok {
 		return v.(uuid.UUID), nil
 	}
+	userUID, err := c.getUserUIDByOwner(owner)
+	if err != nil {
+		return uuid.Nil, err
+	}
+	c.ownerUsrUIDMap.Store(owner, userUID)
+	return userUID, nil
+}
+
+func (c *Cockroach) getUserUIDByOwner(owner string) (uuid.UUID, error) {
 	var user struct {
 		UID uuid.UUID `gorm:"column:userUid;type:uuid"`
 	}
@@ -491,15 +500,24 @@ func (c *Cockroach) getUserUIDByOwnerWithCache(owner string) (uuid.UUID, error)
 		}
 		return uuid.Nil, fmt.Errorf("failed to get userUID: %v", err)
 	}
-	c.ownerUsrUIDMap.Store(owner, user.UID)
 	return user.UID, nil
 }
 
-func (c *Cockroach) getUserIDByOwner(owner string) (string, error) {
-	if v, ok := c.ownerUsrIDMap.Load(owner); ok {
-		return v.(string), nil
+func (c *Cockroach) getUserIDByOwner(owner string, withCache bool) (string, error) {
+	if withCache {
+		if v, ok := c.ownerUsrIDMap.Load(owner); ok {
+			return v.(string), nil
+		}
+	}
+	var (
+		userUID uuid.UUID
+		err     error
+	)
+	if withCache {
+		userUID, err = c.getUserUIDByOwnerWithCache(owner)
+	} else {
+		userUID, err = c.getUserUIDByOwner(owner)
 	}
-	userUID, err := c.getUserUIDByOwnerWithCache(owner)
 	if err != nil {
 		return "", err
 	}

controllers/pkg/types/dbquery.go

@@ -21,11 +21,12 @@ import (
 )
 
 type UserQueryOpts struct {
-	UID         uuid.UUID
-	ID          string
-	Namespace   string
-	Owner       string
-	IgnoreEmpty bool
+	UID          uuid.UUID
+	WithOutCache bool
+	ID           string
+	Namespace    string
+	Owner        string
+	IgnoreEmpty  bool
 }
 
 type GetTransfersReq struct {