Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle Hough Transform improvements #1499

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Nov 5, 2024

  • Fix segfault that occured when creating a vpCHT using a path towards a JSON file (mp_mask was not set to nullptr)
  • Improved the vpCHT tutorial

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (e057281) to head (18e43f8).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
...ules/imgproc/src/vpCircleHoughTransform_common.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   53.90%   53.88%   -0.02%     
==========================================
  Files         442      442              
  Lines       53793    53793              
==========================================
- Hits        28996    28987       -9     
- Misses      24797    24806       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit 842991b into lagadic:master Nov 5, 2024
78 checks passed
@rolalaro rolalaro deleted the tuto_cht branch November 6, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants