Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Mode: Icons for memories too small #24

Open
lah7 opened this issue Mar 3, 2022 · 4 comments
Open

Live Mode: Icons for memories too small #24

lah7 opened this issue Mar 3, 2022 · 4 comments
Labels
visual bug A visual bug that only happens after patching

Comments

@lah7
Copy link
Owner

lah7 commented Mar 3, 2022

Also note the misalignment on the left (#11)

small-memories
@lah7 lah7 added the visual bug A visual bug that only happens after patching label Mar 3, 2022
@lah7 lah7 changed the title Live Mode: Icons for memories still small Live Mode: Icons for memories too small Mar 3, 2022
@lah7
Copy link
Owner Author

lah7 commented Mar 5, 2022

Likewise, some of the wants/fears are small too, possibly the same icon asset?

Screenshot_20220305_155508

@lingeringwillx
Copy link
Contributor

There are icons for the memories in the objects.package file for the latest expansion. They can be found in the same groups as the objects that start with the word Memory (Also objects type is memory). The icons have the IMG entry type. Perhaps upscaling them would fix this?

@lah7
Copy link
Owner Author

lah7 commented Jun 13, 2024 •
edited
Loading

Sorry it's been over a year: Thank you very much for the tip!

I'm currently reworking parts of my DBPF module. At the moment, when my module reads objects.package, it eats up 20 GB+ of RAM and runs out of system memory. 😁 I imagine it's because I made a change fcde15c to decompress everything into memory first, but I guess that won't work with this package if it has different data types that should be left untouched.

Once I sort that out, I'll add objects.package to the list, which hopefully helps with #25. 🤞🏼

PS. I created a v0.1.0 release with a build of the patcher. In terms of visual bugs, it is relatively the same as the past year or two.

@lingeringwillx
Copy link
Contributor

I noticed that your DBPF library doesn't support index minor version 2 (indexes with resource IDs), maybe that's the problem?

lah7 added a commit that referenced this issue Jun 24, 2024
@lah7
DBPF: Add support index version 7.2
f38c5b0 
I was vaguely aware of a newer index version when I implemented
the module, but the version number documented on wiki(s) and
the actual file itself had a discrepancy.

The game still uses DBPF v1.1, but index version:
- 7.1 for "ui.package" (for the patched files so far)
- 7.2 for "objects.package" (#24), an additional "Resource ID" field

SimPE refers to it as "short file index" (0x01) and "long file index"
(0x02). Wiki(s) may be inaccurately saying 7.1, and could have meant
greater than v7.1 (>=7.2), hence the confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
visual bug A visual bug that only happens after patching
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lah7 @lingeringwillx