Add Font::width(char) overload
#1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when we want to iterate through a string, successively building up the length, and checking some condition, it may be easier to have convenient access to the widths of individual characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it may be more convenient, or possibly even more efficient if we could get the
widthof individualcharelements. Perhaps to build up a string of some unknown length, that must fit within a given pixel limit.There was some iteration in OPHD in
TextField::onMouseDownthat was sub-optimal. Instead of a single loop, incrementing by individual character widths, it had a call toFont::width(std::string_view) const, which resulted in a nested loop, and a lot of wasted effort as the width of the entire string was recalculated for each newcharadded. It could have passed each newcharas it's ownstd::string_view, though that still seems like extra work for a simple operation.Related:
Fontsupport for string size fitting #1311TextField::onMouseDownscroll support OutpostUniverse/OPHD#1872