Add RectangleSkin::minSize
#1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is always used with `int` based `Rectangle` in downstream OPHD. Indeed, it makes the most sense to use `int` values with this class. It uses `Image`, which has `int` based `size` values.
The corner images are always unconditionally drawn full size. If the draw `rect` wasn't at least big enough for the corner images, then `RectangleSkin` would draw outside of the bounds set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure a
RectangleSkinmeets a certain minimum size before trying to draw it.The corner images are always drawn at their natural size, without any kind of clipping or stretching. If the draw
rectisn't at least big enough for these images, it will either draw outside of the given bounds, or draw over opposite corner images. Either way the result won't look good.Convert
RectangleparameterBaseTypefromfloattoint. All uses pass inintbasedRectangleinstances, and reallyintis the only type that really makes sense for this class. All theImagecomponents haveintbased sizes.Related: