Swap ResourceCache find vs create blocks
#1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we update how objects are created to allow for factory functions, then we should perhaps not assume an equivalent iterator will be available, or is the best way to get a reference to the new object. Maybe better to assume we can directly return a reference to the newly created object.
It makes more sense to associate the code that returns an existing cached object with the code to `find` that object. The code to create a new object can have it's own way to return a reference to the newly created resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bit of cleanup that may make it easier to work on the
ResourceCachefactory function idea.Related: