Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Alliance Highscores #429

Open
jackbayliss opened this issue Oct 31, 2024 · 2 comments
Open

[BUG] Alliance Highscores #429

jackbayliss opened this issue Oct 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jackbayliss
Copy link
Collaborator

Describe the bug
When using the alliance type on the highscore view, it returns an error in the console and doesn't return anything.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /highscore
  2. Click on the alliance button
  3. View console
  4. See error

Expected behavior
I would expect it to load and show the highscores

Screenshots
image

Additional context
May be expected, i.e. perhaps not implemented yet?

@jackbayliss jackbayliss added the bug Something isn't working label Oct 31, 2024
@lanedirt
Copy link
Owner

Hi @jackbayliss,

Thanks for reporting this issue. The alliance system has indeed not been implemented yet (see #13), so therefore there are no highscores to show yet. But good to have an issue for implementing the alliance highscores in particular.

The error is likely caused by specific JavaScript variables that haven't been declared on the alliance high score page yet. I have encountered similar errors while implementing features in other places as well.

This specific javascript error can probably be fixed already by setting an empty javascript variable so at least the page loads without errors. But we can also wait with addressing this issue until work begins on the alliance system itself.

@jackbayliss
Copy link
Collaborator Author

@lanedirt awesome I did think it wasn't implemented but always worth raising 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants