Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Error 500 Occurs After Combat Between 3000 Light Fighters and Leaderboard Player #1 (Moon Chance Involved) #503

Open
SuGolYolLom opened this issue Dec 18, 2024 · 1 comment
Labels
bug Something isn't working fleet dispatch system Issues regarding the fleet dispatch system

Comments

@SuGolYolLom
Copy link
Contributor

Describe the bug
When engaging in combat with 3000 Light Fighters against Player # 1 on the leaderboard, the system encounters an Error 500 after the battle concludes. This issue appears specifically when moon chance is calculated as part of the battle's outcome.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure that you have 3000 Light Fighters in your fleet
  2. Initiate an attack on Player # 1's planet
  3. Wait for the battle to conclude
  4. Try to navigate to another page / Clear cookies and try to login
  5. Error 500

Expected behavior
The combat should resolve successfully, and the battle report, including the moon chance calculation, should display correctly without errors.

Observed Result:
The game throws an Error 500, preventing access to the battle report or any post-combat interactions.

Screenshots
If applicable, add screenshots to help explain your problem.
K7w87r3
T0gFCv5

Additional context
Add any other context about the problem here.

@SuGolYolLom SuGolYolLom added the bug Something isn't working label Dec 18, 2024
@lanedirt
Copy link
Owner

Hi @SuGolYolLom,

Thanks for the bug report! I just checked it on the main.ogamex.dev environment and the issue seems to be related to #406. More specific: the defending player in your attack mission has around 28 million destroyer units on their planet, and with this large amount of units the battle engine crashes because PHP gets an out-of-memory exception as it hits its 1GB limit.

Issue #406 explains the cause and so the battle engine should be refactored so it can support a larger amount of units. The current battle engine seems to cap at around 1 million units, more than that and it crashes.

In the meantime I have cancelled the fleet mission for your account so at least the HTTP 500 error is gone and you can access your account again.

@lanedirt lanedirt added the fleet dispatch system Issues regarding the fleet dispatch system label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fleet dispatch system Issues regarding the fleet dispatch system
Projects
None yet
Development

No branches or pull requests

2 participants