Issue: incorrect `finish_reason` in OpenAI wrapper?

[dcyriller]

Issue you'd like to raise.

langsmith-sdk/js/src/wrappers/openai.ts

Lines 138 to 143 in dd81f94

	return {
	index: choices[0].index,
	finish_reason: reversedChoices.find((c) => c.finish_reason) || null,
	message: message,
	};
	}

Suggestion:

    return {
        index: choices[0].index,
        finish_reason: reversedChoices.find((c) => c.finish_reason)?.finish_reason || null,
        message: message,
    };

[angus-langchain]

Hi @dcyriller,

Thank you for the suggestion. What is the issue with the current code? You didn't specify what is currently broken or what your change improves

[dcyriller]

Hi @angus-langchain,

Let's take a minimal example (it wouldn't make sense in production, it's just for illustration).

If choices is defined as:

const choices = [
  {    
    index: 0, 
    finish_reason: 'stop', 
    message: 'whatever',
  },
]

The function currently returns:

{ 
  index: 0, 
  finish_reason: { index: 0, finish_reason: 'stop', message: 'whatever' },  // this doesn't seem correct
  message: 'whatever' 
}

Whereas, with the proposed suggestion, the expected result would be:

{ 
  index: 0, 
  finish_reason: 'stop', 
  message: 'whatever' 
}