Skip to content

⚡️ Speed up method SSOConfigService._db_config_to_sso_config by 12% in PR #11399 (feature/sso-implementation) #11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: feature/sso-implementation
Choose a base branch
from
Open

⚡️ Speed up method SSOConfigService._db_config_to_sso_config by 12% in PR #11399 (feature/sso-implementation) #11432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/backend/base/langflow/services/auth/sso_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@

from lfx.log.logger import logger

from langflow.services.auth.sso_config import OIDCConfig, SSOConfig, SSOConfigLoader
from langflow.services.auth.factory import AuthProvider
from langflow.services.auth.sso_config import OIDCConfig, SSOConfig, SSOConfigLoader, SSOProviderConfig

if TYPE_CHECKING:
from sqlmodel.ext.asyncio.session import AsyncSession

from langflow.services.database.models.sso_config.model import SSOConfig as DBSSOConfig
from langflow.services.settings.service import SettingsService

_DEFAULT_SCOPES_TUPLE = ("openid", "email", "profile")


class SSOConfigService:
"""Service for loading SSO configuration from multiple sources.
Expand Down Expand Up @@ -127,20 +130,18 @@ def _db_config_to_sso_config(self, db_config: DBSSOConfig) -> SSOConfig:
Returns:
SSOConfig instance
"""
from langflow.services.auth.factory import AuthProvider
from langflow.services.auth.sso_config import SSOProviderConfig

# Build provider-specific config
provider_config = None

if db_config.provider == "oidc":
is_oidc = db_config.provider == "oidc"
if is_oidc:
provider_config = OIDCConfig(
provider_name=db_config.provider_name,
client_id=db_config.client_id or "",
client_secret=db_config.client_secret_encrypted or "", # Will be decrypted by auth service
discovery_url=db_config.discovery_url or "",
redirect_uri=db_config.redirect_uri or "",
scopes=db_config.scopes.split() if db_config.scopes else ["openid", "email", "profile"],
scopes=db_config.scopes.split() if db_config.scopes else list(_DEFAULT_SCOPES_TUPLE),
email_claim=db_config.email_claim,
username_claim=db_config.username_claim,
user_id_claim=db_config.user_id_claim,
Expand All @@ -155,7 +156,7 @@ def _db_config_to_sso_config(self, db_config: DBSSOConfig) -> SSOConfig:
id=db_config.provider_name.lower().replace(" ", "_"), # Generate ID from provider name
provider_type=AuthProvider(db_config.provider),
enabled=db_config.enabled,
oidc=provider_config if db_config.provider == "oidc" else None,
oidc=provider_config if is_oidc else None,
saml=None, # TODO: Add SAML conversion when implementing SAML
ldap=None, # TODO: Add LDAP conversion when implementing LDAP
)
Expand Down
Loading