Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy DSI backend integration #28

Closed
jpulidojr opened this issue Jun 20, 2023 · 6 comments · Fixed by #120
Closed

SQLAlchemy DSI backend integration #28

jpulidojr opened this issue Jun 20, 2023 · 6 comments · Fixed by #120
Assignees

Comments

@jpulidojr
Copy link
Collaborator

jpulidojr commented Jun 20, 2023

Full SQLAlchemy backend integration after plugin/driver refactor is completed

@jpulidojr jpulidojr self-assigned this Jun 20, 2023
@qwofford
Copy link
Collaborator

Should the SQLAlchemy piece be part of the middleware?

@jpulidojr
Copy link
Collaborator Author

SQLAlchemy can be middleware since it has its own abstract language to create databases, but we can also treat is as a driver because SQLAlchemy has access to multiple types of databases for non-relational data light graph databases.

In SQLAlchemy's dictionary, our "Drivers" are called "Dialects", and that toolkit gives you access to PostgreSQL, MySQL, SQLite, Oracle, and Microsoft SQL Server.

@cmahrens
Copy link
Collaborator

We asked this also and we discussed this at the Monday meeting. I think Quincy was pushing for it to be middleware.

@cmahrens
Copy link
Collaborator

Well, I mean "core" if that is what you are also meaning by middleware.

@qwofford
Copy link
Collaborator

qwofford commented Jul 7, 2023

Daniel is taking a look at Pydantic which might be helpful in conjunction with SQLAlchemy. See #51 and https://github.com/tiangolo/pydantic-sqlalchemy

@qwofford
Copy link
Collaborator

qwofford commented Aug 2, 2023

Optional Pydantic type checking is now in the main branch. If a Plugin implements type checking it can be static or dynamic. An example of static Plugin enforcement can be seen in the Hostname plugin validation model. An example of the dynamic plugin can be seen in the Bueno plugin validation model. It's still possible to create Plugins without Pydantic type enforcement if desired.

Daniel and I are working on code re-structure and documentation based on feedback we received from the group last week, and you can expect changes soon.

@jpulidojr jpulidojr linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants