Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation and examples #3

Open
jbensabat opened this issue May 13, 2020 · 9 comments
Open

Documentation and examples #3

jbensabat opened this issue May 13, 2020 · 9 comments

Comments

@jbensabat
Copy link

Hello
is there any documentation and/or examples for nuflood ?
thanks
jac

@tasseff
Copy link
Member

tasseff commented May 13, 2020

@jbensabat, at the moment, neither are included in this repository. I've wanted to incorporate good documentation and tests for quite a while but unfortunately do not have the time nor funding to do so. Knowing that others like yourself are interested, I may try improving this in my free time, but I cannot guarantee it will be done anytime soon.

@jbensabat
Copy link
Author

jbensabat commented Jul 17, 2020 via email

@tasseff
Copy link
Member

tasseff commented Jul 29, 2020

@jbensabat, sorry for the delay! I will try to add a rainfall-runoff example to this repository over the weekend.

@jbensabat
Copy link
Author

jbensabat commented Jul 29, 2020 via email

@tasseff
Copy link
Member

tasseff commented Aug 2, 2020

@jbensabat, a couple updates. First, I've added a a description of the JSON input fields to DATA.md. Second, I've created an extension repository, nuflood-examples that currently includes a very simple rainfall scenario over a flat surface. I will investigate the addition more complex scenarios, but I hope this is enough to get you started. However, again, the time I can devote to maintaining this project is very limited at the moment, so I cannot promise much.

Your proposal to implement a non-rectangular discretization is interesting. However, I will warn that there would likely be a lot of development effort involved in something like that if you are planning to use the current version of Nuflood as a foundation. The existing I/O routines and models rely quite extensively on the assumption of a rectangular discretization.

@tasseff
Copy link
Member

tasseff commented Aug 2, 2020

Also, absolutely feel free to continue posting additional issues and questions here. I am happy to help.

@jbensabat
Copy link
Author

jbensabat commented Aug 2, 2020 via email

@tasseff
Copy link
Member

tasseff commented Aug 2, 2020

Also, for clarity, I've migrated the examples project to this link (https://github.com/lanl/nuflood-examples). This is different than my initial message, which I've now edited.

@jbensabat
Copy link
Author

jbensabat commented Aug 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants