You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current type annotation usage is in need of some attention:
Many functions and methods still do not have type annotations, e.g. jvp, jhvp, and vjp in scico.operator.
Figure out how to annotate a dynamically generated module so that the typing system is aware of the dynamically constructed functions.
Revisit the numerous lines of code marked as # type: ignore to determine whether the error that led to its insertion can instead be resolved by improved type annotation or use of type guards.
Review class structure with a view to minimization violations of the Liskov substitution principle (e.g. see issues with prox method).
The text was updated successfully, but these errors were encountered:
Current type annotation usage is in need of some attention:
jvp
,jhvp
, andvjp
inscico.operator
.# type: ignore
to determine whether the error that led to its insertion can instead be resolved by improved type annotation or use of type guards.prox
method).The text was updated successfully, but these errors were encountered: