Skip to content

Commit 4ed61e8

Browse files
authored
Merge pull request #492 from leowerneck/main
Updated package.py for singularity-eos to avoid spack.* constructs
2 parents b5a3024 + 0069c67 commit 4ed61e8

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- [[PR444]](https://github.com/lanl/singularity-eos/pull/444) Add Z split modifier and electron ideal gas EOS
1010

1111
### Fixed (Repair bugs, etc)
12+
- [PR492](https://github.com/lanl/singularity-eos/pull/492) Fix import issue in spack's package.py.
1213
- [[PR485]](https://github.com/lanl/singularity-eos/pull/485) Fix segfault in Fortran interface related to EOSPAC initialization
1314
- [[PR478]](https://github.com/lanl/singularity-eos/pull/478) Fix bug in KPT test. Add more extensive clang build to github CI matrix.
1415
- [[PR473]](https://github.com/lanl/singularity-eos/pull/473) Resolve memory issue. Thanks for the catch, Richard!

spack-repo/packages/singularity-eos/package.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@
44

55
import os
66

7+
from spack import spack_version
78
from spack.error import SpackError
89
from spack.package import *
910
from spack.directives import directive
11+
from spack.version import Version
1012

1113

1214
@directive("singularity_eos_plugins")
@@ -168,7 +170,7 @@ class SingularityEos(CMakePackage, CudaPackage, ROCmPackage):
168170
depends_on("kokkos +wrapper+cuda_lambda", when="+cuda+kokkos")
169171

170172
# fix for older spacks
171-
if spack.version.Version(spack.spack_version) >= spack.version.Version("0.17"):
173+
if Version(spack_version) >= Version("0.17"):
172174
depends_on("kokkos-kernels", when="+kokkos-kernels")
173175

174176
for _flag in list(CudaPackage.cuda_arch_values):

0 commit comments

Comments
 (0)