`$model->incrementEach()` affects all models in the database table (instead of just `$model`)

[SjorsO]

Laravel Version

12.28.1

PHP Version

8.4

Database Driver & Version

No response

Description

Bad way to end the week: I just found out a bunch of our production data is corrupt because of this:

// affects just the `$model` database record
$model->increment('number');

// affects all records in the database table 😢 
$model->incrementEach([
    'number' => 1,
    'another_number' => 1,
]); 

This has been reported before in #49009, but that issue was closed.

It's easy to assume that $model->increment() behaves the same way as $model->incrementEach(). Unfortunately, that assumption leads to corrupted production data. Maybe we can keep this issue open this time to try and get this fixed?

Steps To Reproduce

Schema::create('posts', function (Blueprint $table) {
    $table->id();
    $table->unsignedInteger('number')->default(0);
    $table->timestamps();
});


$post1 = Post::create(['number' => 0]);
$post2 = Post::create(['number' => 0]);

$this->assertSame(0, $post1->refresh()->number);
$this->assertSame(0, $post2->refresh()->number);

$post1->incrementEach(['number' => 1]);

$this->assertSame(1, $post1->refresh()->number);
$this->assertSame(0, $post2->refresh()->number); // this fails

[macropay-solutions]

This is linked to the return type of the builder #56664

        if (in_array(strtolower($method), $this->passthru)) {
            return $this->toBase()->{$method}(...$parameters);
        }

If the method is not in $this->passthru the scopes are not applied.

Question is, WHY on some methods the scopes should not be applied. An answer can be the where methods.. So, adding these decrementEach and incrementEach to passtru property will solve (part of) it. See below.

[macropay-solutions]

Only adding decrementEach and incrementEach to passtru does not solve it but at least solved another case (the global scopes).

Working on finishing the fix...

Update.

Preventing this issue is the safest.

Alternatives:

// for unscoped behavior
$model->newQuery()->getQuery()->incrementEach(...)

// for scoped behavior with passtru change
$model->newQuery()->incrementEach(...)

// for scoped behavior with/without passtru change
$model->newQuery()->toBase()->incrementEach(...)

@SjorsO thank you for opening this issue. We patched our projects to prevent this.

[thomasmokuaomweri2011]

Please show some love to the newly introduced fix PR #57302
This could go into the major release as it has a BC