Pending job number seems incorrect

[jasonmccreary]

Horizon Version

5.19.1

Laravel Version

10.19.0

PHP Version

8.2.9

Redis Driver

Predis

Redis Version

1.1.10

Database Driver & Version

No response

Description

It appears the "Pending Jobs" number may be incorrect or misleading when there are failed jobs. This batch is complete and 160 did fail. However, no more are pending.

I would expect this number to be 0 since the batch is complete. Or, if it is to indicate the number of "Incomplete Jobs", then maybe that should have a separate title. Depending on the direction, the "Completed Jobs" and its subtitle might need to be adjusted as currently I would expect it to be 484.

I see the same thing for all my recent batched jobs with failures - the "Pending Jobs" and "Failed Jobs" numbers are the same.

Steps To Reproduce

Run a batched job with some failures. You should see "Pending Jobs" and "Failed Jobs" are the same number.

[driesvints]

Hey @jasonmccreary. I believe these numbers are correct. This view is just a direct representation of the values of a batch in Laravel: https://github.com/laravel/framework/blob/2e3d23fc89c5c9e9841962d5c9bf0e3881a81929/src/Illuminate/Bus/Batch.php#L445-L457

There's pending jobs which are basically the failed jobs which still need to run, there's completed jobs and then there's a total number of jobs (completed + pending/failed).

[jasonmccreary]

Thanks for the explanation. I still wonder if the wording could be adjusted as "pending" to me means needs to be run. I see how "failed" falls into that category though. No biggie.

[driesvints]

I think it's best we just use the wording as is on the batch array personally. You can always try a PR to see if Taylor would accept it 👍

[crynobone]

Total Job value is in fact incorrect, at the moment it calculated from (totals - pendingJobs), when it should show Completed Jobs (including failed) 484 (100%)

horizon/resources/js/screens/batches/preview.vue

Lines 143 to 158 in bea664a

	<div class="row mb-2">
	<div class="col-md-2 text-muted">Total Jobs</div>
	<div class="col">{{batch.totalJobs}}</div>
	</div>
	<div class="row mb-2">
	<div class="col-md-2 text-muted">Pending Jobs</div>
	<div class="col">{{batch.pendingJobs}}</div>
	</div>
	<div class="row mb-2">
	<div class="col-md-2 text-muted">Failed Jobs</div>
	<div class="col">{{batch.failedJobs}}</div>
	</div>
	<div class="row">
	<div class="col-md-2 text-muted">Completed Jobs<br><small>(Including Failed)</small></div>
	<div class="col">{{ (batch.totalJobs-batch.pendingJobs) }} ({{batch.progress}}%)</div>
	</div>

[crynobone]

Alternatively we should follow Illuminate\Bus\Batch conversion of "Processed Jobs" (totals - pendingJobs) and displayed it as Processed Jobs 324 (67%)

[driesvints]

Right, good spot @crynobone. Sorry about that @jasonmccreary

[jasonmccreary]

@driesvints, no worries. Glad it got reopened.

[topclaudy]

Similar issue:

Processed/Completed jobs 100%, no failures but 6 pending (stuck).