Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume resources/js is present #77

Closed
tarreislam opened this issue Mar 13, 2024 · 5 comments
Closed

Don't assume resources/js is present #77

tarreislam opened this issue Mar 13, 2024 · 5 comments
Assignees

Comments

@tarreislam
Copy link

Reverb Version

1.0.0

Laravel Version

11.0

PHP Version

8.3

Description

I am using Laravel purely as a backend HTTP API but your installer assumes /resources/js should exist, which it does not in my case.

Teherefore I get this error when running art install:broadcasting

copy(/var/www/resources/js/echo.js): Failed to open stream: No such file or directory at vendor/laravel/framework/src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php:58

Steps To Reproduce

  1. php artisan install:broadcasting
@joedixon
Copy link
Collaborator

Did you say "No" when the installer asked you if you wish to install the NPM dependencies?

@tarreislam
Copy link
Author

Did you say "No" when the installer asked you if you wish to install the NPM dependencies?

That question is asked after this exception is thrown.

Exception thrown

https://github.com/laravel/framework/blob/11.x/src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php#L57

Question about NPM dependencies
https://github.com/laravel/framework/blob/11.x/src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php#L76

This might be an framework issue and not reverb issue though?

@joedixon
Copy link
Collaborator

It's actually both, going to be working on this today.

@joedixon joedixon self-assigned this Mar 14, 2024
@driesvints
Copy link
Member

@tarreislam did you try this on Laravel v11.0.5? We fixed this here normally: laravel/framework#50519

@tarreislam
Copy link
Author

@tarreislam did you try this on Laravel v11.0.5? We fixed this here normally: laravel/framework#50519

When I upgrade I landed on 11.03, so its probably that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants