-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: "[error] Translation namespaces" #212
Comments
Same error as @patimio66 running on windows 10. Just installed the extension today. |
Taking a look between 1.17 and 1.18, I do see there was a merge that did target language. I do not even pretend to know what is going on, but it does touch language processing and happened between working version and now. All of us appear to be on Windows... A pathing issue? \ vs / |
Yep, it works! |
I'm getting the same error as @patimio66, running on MacOS. Downgrading to 1.17 does apparently fix the issue though. |
Same issue on Windows (Sail via WSL) in version |
Can confirm this is still an issue on Downgrading to version The JSON files are valid, though some strings do include HTML. Idk if that may be throwing off a parser somewhere? |
I removed the |
@joetannenbaum Same issue (not the same error as OP but translation related) on 0.1.19. Errors out after |
Still present: |
Still getting it on .19 |
Yep. The "safe" release is .17 for now...
Atenciosamente,
Otávio Araújo
…________________________________
De: Mo Khosh ***@***.***>
Enviado: Wednesday, February 12, 2025 8:21:22 AM
Para: laravel/vs-code-extension ***@***.***>
Cc: Otávio Araújo ***@***.***>; Comment ***@***.***>
Assunto: Re: [laravel/vs-code-extension] [Bug]: "[error] Translation namespaces" (Issue #212)
Still getting it on .19
—
Reply to this email directly, view it on GitHub<#212 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHIXSG375IRQBDRULCBVBQT2PMVDFAVCNFSM6AAAAABVN4KVT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJTGQZDEMJTGA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Would love to get to the bottom of this, I find it strange that you're getting JSON back but it's still erroring. Does anyone have a public repo I can pull down that replicates this? |
@joetannenbaum maybe it's related to VS Code locale? Like to the settings of VS code? |
My preliminary testing seems to suggest it's not a particular line or language file causing this error but the amount of translation strings. Seemed that there was a certain amount of lines needed (tested with validation translations) to cause this error to appear. Didn't seem matter which particular lines where present. |
Yeah this is what I suspected. I'm tempted to add a setting to omit vendor translations, although I'd love to also have a solution to have them properly included as well. I'll continue investigating. |
We have a lot of translation strings in our app/package (Statamic). I can see the error on any Statamic site I touch. |
Yup, seeing that too with a fresh install just now. Good place to start, thanks @duncanmcclean 👍 |
Just released v0.1.20 that should greatly improve (if not fix) this issue. I completely overhauled the translations collection process and the performance + memory usage is much better now. Let me know how it looks on your end! |
@joetannenbaum looks good on my side! Tried installing the extension from scratch, again, works fine on v0.1.20. |
Issues resolved for me as well, thanks! |
@joetannenbaum New error. I tried reinstall have the same error |
Resolved for me too. Thanks! |
Extension Version
0.1.18
PHP Binary
Local PHP
Operating System
Windows
What happened?
On start of Visual Studio Code :
Mimimal Code Sample
The text was updated successfully, but these errors were encountered: