Incorrect SSO URL construction

[xdgc]

The SSO URL constructor assumes the SSO base URL has no query. Patch below:

diff --git a/src/com/lastpass/jira/SAMLAuthenticator.java b/src/com/lastpass/jira/SAMLAuthenticator.java
index d2aa6ee..251deb5 100644
--- a/src/com/lastpass/jira/SAMLAuthenticator.java
+++ b/src/com/lastpass/jira/SAMLAuthenticator.java
@@ -128,8 +128,11 @@ public class SAMLAuthenticator extends JiraSeraphAuthenticator
         try {
             String authrequest = client.generateAuthnRequest(requestId);
             String url = client.getIdPConfig().getLoginUrl();
-            url = url +
-                "?SAMLRequest=" + URLEncoder.encode(authrequest, "UTF-8");
+            String sep = "?";
+            if (url.indexOf("?") > -1)
+                sep = "&";
+            url = url + sep +
+                "SAMLRequest=" + URLEncoder.encode(authrequest, "UTF-8");

             if (relayState != null)
                 url += "&RelayState=" + URLEncoder.encode(relayState, "UTF-8");

[xdgc]

(This permits the plugin to work with Google SSO.)

[xdgc]

Would it be helpful to submit this as a pull request?

[xdgc]

Is anyone still maintaining this code? I've brought it up with LastPass Support and no response there either.

[bcopeland]

This change looks fine to me. But I haven't worked at LastPass for over a year so I can't help merge it.

[xdgc]

Thanks for the review, @bcopeland — I realize you're no longer there, so I appreciate your followup and hope it's helpful for the new management.