Add fixer-level "ignore" option, fix file filtering in custom fixers (#19)

---------

Co-authored-by: Fix-it Felix[bot] <[email protected]>

Author: aengelberg

.felixrc.json

@@ -1,5 +1,5 @@
 {
-  "fixers": ["eslint", "prettier"],
+  "fixers": ["eslint", "prettier", "wc"],
   "paths": ["src/**", "examples/**", "tests/**", "*.md", "jest.config.js", "test-felix.js"],
   "ignore": ["node_modules/**", "dist/**", "build/**", ".git/**", "coverage/**", "test-files/**", "package.json", "package-lock.json", ".github/**"],
   "_comment": "Using custom commands to demonstrate the feature. In production, ensure 'npm ci' runs before Felix.",
@@ -10,5 +10,10 @@
   "prettier": {
     "command": ["npm", "run", "format:fix"],
     "appendPaths": false
+  },
+  "wc": {
+    "command": ["wc", "-l"],
+    "ignore": [".felixrc.json"],
+    "paths": ["."]
   }
 }

dist/index.js

@@ -30021,6 +30021,12 @@ class ConfigManager {
     getIgnorePatterns() {
         return this.config.ignore || ['node_modules/**', 'dist/**', 'build/**', '.git/**'];
     }
+    getFixerIgnorePatterns(fixerName) {
+        const globalIgnores = this.getIgnorePatterns();
+        const fixerConfig = this.getFixerConfig(fixerName);
+        const localIgnores = Array.isArray(fixerConfig.ignore) ? fixerConfig.ignore : [];
+        return [...globalIgnores, ...localIgnores];
+    }
     getFixerConfig(fixerName) {
         return this.config[fixerName] || {};
     }
@@ -30602,6 +30608,8 @@ To apply these fixes, remove the \`dry_run: true\` option from your workflow.`;
         return this.config.getPaths();
     }
     filterFilesByFixer(files, fixerName, fixerConfig, configuredPaths) {
+        // Gather ignore patterns (global + fixer-level)
+        const ignorePatterns = this.config.getFixerIgnorePatterns(fixerName);
         // Get the extensions this fixer handles
         let extensions = [];
         switch (fixerName) {
@@ -30644,16 +30652,27 @@ To apply these fixes, remove the \`dry_run: true\` option from your workflow.`;
                 extensions = fixerConfig.extensions || ['.md', '.markdown'];
                 break;
             default:
-                return files;
+                extensions = fixerConfig.extensions || [];
+                break;
         }
+        const isIgnored = (filePath) => {
+            return ignorePatterns.some(pattern => (0, minimatch_1.minimatch)(filePath, pattern));
+        };
         if (this.inputs.debug) {
             core.info(`🔍 Debug: Filtering ${files.length} files for ${fixerName}`);
             core.info(`🔍 Debug: Extensions: ${extensions.join(', ')}`);
+            core.info(`🔍 Debug: Ignore patterns (${ignorePatterns.length}): ${ignorePatterns.join(', ')}`);
             core.info(`🔍 Debug: Configured paths: ${configuredPaths.join(', ')}`);
         }
         const filteredFiles = files.filter(file => {
             const ext = path.extname(file).toLowerCase();
-            if (!extensions.includes(ext)) {
+            if (isIgnored(file)) {
+                if (this.inputs.debug) {
+                    core.info(`🔍 Debug: Excluded ${file}: matches ignore patterns`);
+                }
+                return false;
+            }
+            if (extensions.length > 0 && !extensions.includes(ext)) {
                 if (this.inputs.debug) {
                     core.info(`🔍 Debug: Excluded ${file}: extension ${ext} not in allowed extensions`);
                 }
@@ -31305,7 +31324,7 @@ class PrettierFixer extends base_1.BaseFixer {
         if (!this.configManager) {
             return paths;
         }
-        const ignorePatterns = this.configManager.getIgnorePatterns();
+        const ignorePatterns = this.configManager.getFixerIgnorePatterns(this.name);
         return paths.filter(path => {
             const cleanPath = path.endsWith('/') ? path.slice(0, -1) : path;
             // Check if this path matches any ignore pattern

dist/index.js.map

@@ -70,6 +70,13 @@ export class ConfigManager {
     return this.config.ignore || ['node_modules/**', 'dist/**', 'build/**', '.git/**']
   }
 
+  getFixerIgnorePatterns(fixerName: string): string[] {
+    const globalIgnores = this.getIgnorePatterns()
+    const fixerConfig = this.getFixerConfig(fixerName)
+    const localIgnores = Array.isArray(fixerConfig.ignore) ? fixerConfig.ignore : []
+    return [...globalIgnores, ...localIgnores]
+  }
+
   getFixerConfig(fixerName: string): any {
     return this.config[fixerName as keyof FelixConfig] || {}
   }

src/config.ts

@@ -607,6 +607,9 @@ To apply these fixes, remove the \`dry_run: true\` option from your workflow.`
     fixerConfig: any,
     configuredPaths: string[]
   ): string[] {
+    // Gather ignore patterns (global + fixer-level)
+    const ignorePatterns = this.config.getFixerIgnorePatterns(fixerName)
+
     // Get the extensions this fixer handles
     let extensions: string[] = []
 
@@ -650,19 +653,34 @@ To apply these fixes, remove the \`dry_run: true\` option from your workflow.`
         extensions = fixerConfig.extensions || ['.md', '.markdown']
         break
       default:
-        return files
+        extensions = fixerConfig.extensions || []
+        break
+    }
+
+    const isIgnored = (filePath: string): boolean => {
+      return ignorePatterns.some(pattern => minimatch(filePath, pattern))
     }
 
     if (this.inputs.debug) {
       core.info(`🔍 Debug: Filtering ${files.length} files for ${fixerName}`)
       core.info(`🔍 Debug: Extensions: ${extensions.join(', ')}`)
+      core.info(
+        `🔍 Debug: Ignore patterns (${ignorePatterns.length}): ${ignorePatterns.join(', ')}`
+      )
       core.info(`🔍 Debug: Configured paths: ${configuredPaths.join(', ')}`)
     }
 
     const filteredFiles = files.filter(file => {
       const ext = path.extname(file).toLowerCase()
 
-      if (!extensions.includes(ext)) {
+      if (isIgnored(file)) {
+        if (this.inputs.debug) {
+          core.info(`🔍 Debug: Excluded ${file}: matches ignore patterns`)
+        }
+        return false
+      }
+
+      if (extensions.length > 0 && !extensions.includes(ext)) {
         if (this.inputs.debug) {
           core.info(`🔍 Debug: Excluded ${file}: extension ${ext} not in allowed extensions`)
         }

src/felix.ts

@@ -32,7 +32,7 @@ export class PrettierFixer extends BaseFixer {
       return paths
     }
 
-    const ignorePatterns = this.configManager.getIgnorePatterns()
+    const ignorePatterns = this.configManager.getFixerIgnorePatterns(this.name)
     return paths.filter(path => {
       const cleanPath = path.endsWith('/') ? path.slice(0, -1) : path
 

src/fixers/prettier.ts

@@ -21,19 +21,22 @@ export interface FelixConfig {
     paths?: string[]
     command?: string[]
     appendPaths?: boolean
+    ignore?: string[]
   }
   prettier?: {
     configFile?: string
     extensions?: string[]
     paths?: string[]
     command?: string[]
     appendPaths?: boolean
+    ignore?: string[]
   }
   markdownlint?: {
     configFile?: string
     paths?: string[]
     command?: string[]
     appendPaths?: boolean
+    ignore?: string[]
   }
 }