SwiftLint - address lint violations #441
Description
There are ~80 SwiftLint rule violations. They should be addressed, or explicitly ignored.
➜ ios-client-sdk git:(feature/sl-059) swiftlint .
warning: 'unused_declaration' should be listed in the 'analyzer_rules' configuration section for more clarity as it is only run by 'swiftlint analyze'.
warning: 'unused_import' should be listed in the 'analyzer_rules' configuration section for more clarity as it is only run by 'swiftlint analyze'.
Linting Swift files at paths .
Linting 'FlagMaintainingMock.swift' (1/47)
Linting 'DarklyServiceMock.swift' (2/47)
Linting 'LDEventSourceMock.swift' (3/47)
Linting 'ClientServiceMockFactory.swift' (4/47)
Linting 'EnvironmentReportingMock.swift' (5/47)
Linting 'LDContextStub.swift' (6/47)
Linting 'LDConfigStub.swift' (7/47)
Linting 'LDTimerSpec.swift' (8/47)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Mocks/ClientServiceMockFactory.swift:44:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Mocks/ClientServiceMockFactory.swift:94:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 7 (function_parameter_count)
Linting 'FeatureFlagCacheSpec.swift' (9/47)
Linting 'CacheConverterSpec.swift' (10/47)
Linting 'DiagnosticCacheSpec.swift' (11/47)
Linting 'SynchronizingErrorSpec.swift' (12/47)
Linting 'FlagStoreSpec.swift' (13/47)
Linting 'ApplicationInfoEnvironmentReporterSpec.swift' (14/47)
Linting 'FlagSynchronizerSpec.swift' (15/47)
Linting 'IOSEnvironmentReporterSpec.swift' (17/47)
Linting 'WatchOSEnvironmentReporterSpec.swift' (16/47)
Linting 'EnvironmentReporterChainBaseSpec.swift' (18/47)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/ServiceObjects/SynchronizingErrorSpec.swift:12:16: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional `Data(_:)` initializer when converting `String` to `Data` (non_optional_string_data_conversion)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/ServiceObjects/Cache/CacheConverterSpec.swift:12:5: warning: Static Over Final Class Violation: Prefer `static` over `class` in a final class (static_over_final_class)
Linting 'EventReporterSpec.swift' (19/47)
Linting 'SheddingQueueSpec.swift' (21/47)
Linting 'FlagChangeNotifierSpec.swift' (20/47)
Linting 'DiagnosticReporterSpec.swift' (22/47)
Linting 'ThrottlerSpec.swift' (23/47)
Linting 'LDClientHookSpec.swift' (25/47)
Linting 'LDClientSpec.swift' (24/47)
Linting 'HTTPHeadersSpec.swift' (26/47)
Linting 'URLRequestSpec.swift' (27/47)
Linting 'DarklyServiceSpec.swift' (28/47)
Linting 'HTTPURLResponse.swift' (29/47)
Linting 'LDContextCodableSpec.swift' (30/47)
Linting 'LDContextSpec.swift' (32/47)
Linting 'ModifierSpec.swift' (31/47)
Linting 'ReferenceSpec.swift' (33/47)
Linting 'KindSpec.swift' (34/47)
Linting 'LDConfigSpec.swift' (35/47)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/Context/LDContextCodableSpec.swift:49:84: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/Context/LDContextCodableSpec.swift:49:129: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/Context/LDContextCodableSpec.swift:49:89: warning: Comma Spacing Violation: There should be no space before and one after any comma (comma)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:360:32: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:368:32: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:618:32: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:1043:36: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:1094:12: warning: Todo Violation: TODOs should be resolved ((os-tests): These tests won't ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:1278:24: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:71:29: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:114:29: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:158:33: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:196:33: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:229:25: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift:242:25: warning: Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
Linting 'FeatureFlagSpec.swift' (36/47)
Linting 'FlagChangeObserverSpec.swift' (37/47)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/LDConfigSpec.swift:101:16: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/LDConfigSpec.swift:201:16: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/LDConfigSpec.swift:212:16: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
Linting 'FlagCounterSpec.swift' (38/47)
Linting 'FlagRequestTrackerSpec.swift' (39/47)
Linting 'EventSpec.swift' (41/47)
Linting 'DiagnosticEventSpec.swift' (40/47)
Linting 'TestContext.swift' (42/47)
Linting 'ThreadSpec.swift' (43/47)
Linting 'UtilSpec.swift' (45/47)
Linting 'LDValueDecoderSpec.swift' (44/47)
Linting 'SDKEnvironmentReporterSpec.swift' (46/47)
Linting 'TestUtil.swift' (47/47)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/LDValueDecoderSpec.swift:69:17: warning: Nesting Violation: Types should be nested at most 1 level deep (nesting)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/DiagnosticEventSpec.swift:119:28: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/DiagnosticEventSpec.swift:235:24: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarklyTests/Models/DiagnosticEventSpec.swift:356:20: warning: Todo Violation: TODOs should be resolved ((os-tests): We need to expand ...) (todo)
Linting 'Throttler.swift' (1/69)
Linting 'NetworkReporter.swift' (2/69)
Linting 'FeatureFlagCache.swift' (3/69)
Linting 'EnvironmentReporter.swift' (4/69)
Linting 'KeyedValueCache.swift' (5/69)
Linting 'ConnectionInformationStore.swift' (6/69)
Linting 'DiagnosticCache.swift' (7/69)
Linting 'CacheConverter.swift' (8/69)
Linting 'Log.swift' (9/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/Cache/FeatureFlagCache.swift:34:66: warning: Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/Cache/FeatureFlagCache.swift:84:66: warning: Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Linting 'SheddingQueue.swift' (10/69)
Linting 'ClientServiceFactory.swift' (11/69)
Linting 'SystemCapabilities.swift' (12/69)
Linting 'EnvironmentReporterBuilder.swift' (13/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/Throttler.swift:25:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/Throttler.swift:26:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
Linting 'WatchOSEnvironmentReporter.swift' (14/69)
Linting 'SDKEnvironmentReporter.swift' (15/69)
Linting 'TVOSEnvironmentReporter.swift' (16/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/ClientServiceFactory.swift:11:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/ClientServiceFactory.swift:20:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 7 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/ClientServiceFactory.swift:56:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/ClientServiceFactory.swift:81:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 7 (function_parameter_count)
Linting 'ApplicationInfoEnvironmentReporter.swift' (17/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/EnvironmentReporting/EnvironmentReporterBuilder.swift:46:13: warning: Identifier Name Violation: Variable name 'i' should be between 3 and 50 characters long (identifier_name)
Linting 'IOSEnvironmentReporter.swift' (18/69)
Linting 'MacOSEnvironmentReporter.swift' (19/69)
Linting 'EnvironmentReporterChainBase.swift' (20/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/SheddingQueue.swift:56:21: warning: Empty Parentheses with Trailing Closure Violation: When using trailing closures, empty parentheses should be avoided after the method call (empty_parentheses_with_trailing_closure)
Linting 'ReportingConsts.swift' (21/69)
Linting 'DiagnosticReporter.swift' (22/69)
Linting 'CwlSysctl.swift' (23/69)
Linting 'FlagStore.swift' (24/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/EnvironmentReporting/EnvironmentReporterChainBase.swift:15:16: warning: Identifier Name Violation: Variable name 'n' should be between 3 and 50 characters long (identifier_name)
Linting 'EventReporter.swift' (25/69)
Linting 'FlagChangeNotifier.swift' (26/69)
Linting 'FlagSynchronizer.swift' (27/69)
Linting 'LDTimer.swift' (28/69)
Linting 'URLResponse.swift' (29/69)
Linting 'HTTPHeaders.swift' (30/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/FlagChangeNotifier.swift:17:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/FlagChangeNotifier.swift:18:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/FlagChangeNotifier.swift:19:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
Linting 'HTTPURLResponse.swift' (31/69)
Linting 'DarklyService.swift' (32/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/LDTimer.swift:12:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/LDTimer.swift:15:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/LDTimer.swift:24:16: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 50 characters long (identifier_name)
Linting 'HTTPURLRequest.swift' (33/69)
Linting 'LDValueDecoder.swift' (34/69)
Linting 'LDClient.swift' (35/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Networking/DarklyService.swift:6:29: error: Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
Linting 'Reference.swift' (36/69)
Linting 'Kind.swift' (37/69)
Linting 'LDContext.swift' (38/69)
Linting 'Modifier.swift' (39/69)
Linting 'Event.swift' (40/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDClient.swift:39:8: error: Type Body Length Violation: Type body should span 500 lines or less excluding comments and whitespace: currently spans 518 lines (type_body_length)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/EventReporter.swift:39:13: error: Attribute Name Spacing Violation: There must not be any space between access control modifier and scope (attribute_name_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ServiceObjects/EventReporter.swift:25:5: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
Linting 'ConnectionInformation.swift' (41/69)
Linting 'DiagnosticEvent.swift' (42/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:14:3: warning: Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:24:3: warning: Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:71:3: warning: Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:73:3: warning: Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:217:16: warning: Compiler Protocol Init Violation: Initializers declared in compiler protocol ExpressibleByFloatLiteral shouldn't be called directly (compiler_protocol_init)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:220:49: warning: Identifier Name Violation: Variable name 'as' should be between 3 and 50 characters long (identifier_name)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:392:9: warning: Nesting Violation: Types should be nested at most 1 level deep (nesting)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:249:5: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:261:5: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:495:9: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:682:9: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:3:1: warning: Orphaned Doc Comment Violation: A doc comment should be attached to a declaration (orphaned_doc_comment)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:61:1: warning: Private over Fileprivate Violation: Prefer `private` over `fileprivate` declarations (private_over_fileprivate)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:111:1: warning: Private over Fileprivate Violation: Prefer `private` over `fileprivate` declarations (private_over_fileprivate)
ios-client-sdk/LaunchDarkly/LaunchDarkly/LDValueDecoder.swift:409:20: warning: Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
Linting 'LDEvaluationDetail.swift' (43/69)
Linting 'FlagRequestTracker.swift' (44/69)
Linting 'FlagChangeObserver.swift' (45/69)
Linting 'FlagsUnchangedObserver.swift' (46/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/Modifier.swift:57:31: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/Modifier.swift:87:31: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/Modifier.swift:145:88: warning: Colon Spacing Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
Linting 'LDChangedFlag.swift' (47/69)
Linting 'ConnectionModeChangeObserver.swift' (48/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:476:12: warning: Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 14 (cyclomatic_complexity)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:723:21: warning: Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:476:12: warning: Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 67 lines (function_body_length)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:123:20: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 7 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:161:20: warning: Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 8 (function_parameter_count)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:53:44: warning: Identifier Name Violation: Variable name 'c' should be between 3 and 50 characters long (identifier_name)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:512:20: warning: Identifier Name Violation: Variable name 'ip' should be between 3 and 50 characters long (identifier_name)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:606:55: warning: Identifier Name Violation: Enum element name 'ip' should be between 3 and 50 characters long (identifier_name)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:71:9: warning: Nesting Violation: Types should be nested at most 1 level deep (nesting)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:176:16: warning: Todo Violation: TODOs should be resolved ((mmk): This might be a problem...) (todo)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/Context/LDContext.swift:25:8: warning: Type Body Length Violation: Type body should span 300 lines or less excluding comments and whitespace: currently spans 330 lines (type_body_length)
Linting 'LDConfig.swift' (49/69)
Linting 'Metadata.swift' (50/69)
Linting 'FeatureFlag.swift' (51/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/FeatureFlag/FlagChange/LDChangedFlag.swift:18:5: warning: Unneeded Synthesized Initializer Violation: This memberwise initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
Linting 'EvaluationSeriesContext.swift' (52/69)
Linting 'Hook.swift' (53/69)
Linting 'IdentifyTypes.swift' (54/69)
Linting 'Date.swift' (55/69)
Linting 'Data.swift' (56/69)
Linting 'Thread.swift' (57/69)
Linting 'DateFormatter.swift' (58/69)
Linting 'Util.swift' (59/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/LDConfig.swift:426:8: warning: Todo Violation: TODOs should be resolved (find a way to make delegates e...) (todo)
Linting 'LDCommon.swift' (60/69)
Linting 'LDClientVariation.swift' (61/69)
Linting 'ObjcLDChangedFlag.swift' (62/69)
Linting 'ObjcLDContext.swift' (63/69)
Linting 'ObjcLDApplicationInfo.swift' (64/69)
Linting 'ObjcLDEvaluationDetail.swift' (65/69)
Linting 'ObjcLDConfig.swift' (66/69)
Linting 'ObjcLDReference.swift' (67/69)
Linting 'ObjcLDClient.swift' (68/69)
Linting 'ObjcLDValue.swift' (69/69)
ios-client-sdk/LaunchDarkly/LaunchDarkly/Models/IdentifyTypes.swift:46:10: warning: Identifier Name Violation: Enum element name 'no' should be between 3 and 50 characters long (identifier_name)
ios-client-sdk/LaunchDarkly/LaunchDarkly/ObjectiveC/ObjcLDConfig.swift:175:1: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
Done linting! Found 80 violations, 10 serious in 116 files.