[Feature Request] Binary websocket traffic

[Gelbpunkt]

Hi,

my personal usecase is that I want to encode JSON more efficiently in Python to send it over the websocket and one of the best ways is to use alternate JSON encoders like orjson which encode to bytes instead of strings. Decoding those to strings before sending them over the websocket connection feels like an unnecessary overhead.

Current, Lavalink rejects any binary websocket traffic, so I am wondering if it would be possible to add support for it. From what I've experienced in languages such as Rust or Python, JSON decoding from bytes can also be more efficient than from strings, so it might be a beneficial addition on both sides. Either way I imagine this to be easy to implement and one of the small things that can make a nice difference.

[freyacodes]

This is difficult to implement with the library we are currently using. I'm not aware of a JVM library that takes both JSON and BSON.

The performance overhead is likely negligible.

[DRSchlaubi]

This is difficult to implement with the library we are currently using. I'm not aware of a JVM library that takes both JSON and BSON.

The performance overhead is likely negligible.

it should be possible with kotlinx.serialization, so this might be possible with not that much effort

[JellyBrick]

This is difficult to implement with the library we are currently using. I'm not aware of a JVM library that takes both JSON and BSON.

The performance overhead is likely negligible.

it should be possible with kotlinx.serialization, so this might be possible with not that much effort

In addition to the methods described above, this feature can be implement by using https://github.com/FasterXML/jackson-datatypes-misc in the current implementation. (without major code refactoring)

Additional comment: BSON is inefficient compared to other binary data format.
Sometimes BSON takes longer to parse than JSON.

[freyacodes]

I am still not convinced that this is an optimization that is worth bothering with. The transmission of WebSocket events is magnitudes smaller than all the other network traffic that Lavalink does