feat: fix fallback with latest or nightly release

Author: laytan

.github/workflows/test.yml

@@ -42,7 +42,7 @@ jobs:
   test-release:
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest, macos-14] # macos-14 is an arm machine.
+        os: [ubuntu-latest, windows-latest, macos-latest, macos-14, ubuntu-24.04-arm] # macos-14 is an arm machine, #ubuntu-24.04-arm should fall back to building from source.
         release: [latest, dev-2024-05, nightly]
     runs-on: ${{ matrix.os }}
     steps:

dist/cache-save/index.js

@@ -44,6 +44,8 @@ function getInputs() {
   if (release && release.length > 0) {
     if (release == "false" || release == "False" || release == "FALSE") {
       release = "";
+    } else if (release == "nightly" || release == "latest") {
+      branch = "master";
     } else {
       branch = release;
     }

dist/cache-save/index.js.map

@@ -24,12 +24,24 @@ async function run() {
 
     const odinPath = common.odinPath();
     core.addPath(odinPath);
+    if (inputs.release !== "") {
+      const releaseResult = await downloadRelease(inputs);
+      if (releaseResult.ok) {
+        await finalizeRelease(inputs);
+        core.setOutput('cache-hit', false);
+        core.saveState('cache-hit', 'false');
+        return;
+      }
 
-    if (inputs.release !== "" && await downloadRelease(inputs)) {
-      await finalizeRelease(inputs);
-      core.setOutput('cache-hit', false);
-      core.saveState('cache-hit', 'false');
-      return;
+      if (releaseResult.fallback === false) {
+        core.setOutput('cache-hit', false);
+        core.saveState('cache-hit', 'false');
+        return;
+      }
+
+      if (typeof releaseResult.fallback === 'string') {
+        inputs.branch = releaseResult.fallback;
+      }
     }
 
     if (common.cacheCheck(inputs)) {
@@ -235,22 +247,32 @@ async function pullOdinBuildDependencies(inputs) {
 /**
   * @param inputs {common.Inputs}
   *
-  * @return Promise<bool> Whether to return or fallback to git based install.
+  * @return Promise<{ok: bool, fallback: bool|string}>
   */
 async function downloadRelease(inputs) {
   if (inputs.release == 'nightly') {
-    return downloadNightlyRelease(inputs);
+    const nightlyOk = await downloadNightlyRelease(inputs);
+    return {
+      ok: nightlyOk,
+      fallback: false,
+    };
   }
 
   const parts = inputs.repository.split('/');
   if (parts.length < 2) {
     core.setFailed(`Invalid repository ${inputs.repository}.`);
-    return true;
+    return {
+      ok: false,
+      fallback: false,
+    };
   }
 
   if (inputs.token == "") {
     core.warning('Invalid access token, falling back to git based install.');
-    return false;
+    return {
+      ok: false,
+      fallback: true,
+    };
   }
 
   const octokit = github.getOctokit(inputs.token);
@@ -290,7 +312,10 @@ async function downloadRelease(inputs) {
 
   if (!asset) {
       core.warning('could not find release asset to download, falling back to git based install.');
-      return false;
+      return {
+        ok: false,
+        fallback: release.tag_name,
+      };
   }
 
   core.debug(asset);
@@ -321,7 +346,11 @@ async function downloadRelease(inputs) {
 
   core.debug(download);
 
-  return extractDownload(download.url, Buffer.from(download.data));
+  const extractOk = await extractDownload(download.url, Buffer.from(download.data));
+  return {
+    ok: extractOk,
+    fallback: false,
+  };
 }
 
 /**