-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
structure fields of a parent structure are not resolved correctly #58
Comments
The same issue also appears in dot-notation: https://github.com/leanprover-community/mathlib3port/blob/9b3a383ce98f5dce5e1b922c8b1614a9befa909a/Mathbin/Topology/ContinuousFunction/Bounded.lean#L42 instance : CoeFun (α →ᵇ β) fun _ => α → β :=
⟨fun f => f.to_fun⟩ |
This commit addresses leanprover-community/mathport#58 (comment) Note that the title and first comment in that issue are unrelated and were addressed by [61b4659b7bcbf2c61b09db8370487b6f78403701](leanprover-community/mathport@61b4659)
This commit addresses leanprover-community/mathport#58 (comment) Note that the title and first comment in that issue are unrelated and were addressed by [61b4659b7bcbf2c61b09db8370487b6f78403701](leanprover-community/mathport@61b4659)
The class category_struct (obj : Type u) extends Quiver.{v + 1} obj : Type max u (v + 1) where
id : ∀ X : obj, hom X X
comp : ∀ {X Y Z : obj}, (X ⟶ Y) → (Y ⟶ Z) → (X ⟶ Z)
-- ...
class category (obj : Type u) extends CategoryStruct.{v} obj : Type max u (v + 1) where (There's also the incorrect |
|
It looks like the parser doesn't actually resolve the |
This was easy to fix, since we can compute the Lean 3 name by namespace name ++ declaration name and then rename it like a constant. #110 |
See https://github.com/leanprover-community/mathlib3port/blob/948275e/Mathbin/CategoryTheory/Category/Basic.lean#L74 for an example. The appearances of
hom
here should beHom
(referring toQuiver.Hom
).Presumably when mathport is looking up these identifiers it is not looking in the
Quiver
namespace, so we will need to add parent structures at the appropriate point in resolution.The text was updated successfully, but these errors were encountered: