Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "Liveness probes values aren't the same as the Readiness" #21

Open
terracota-p opened this issue Nov 20, 2020 · 0 comments
Open

Comments

@terracota-p
Copy link

In Liveness probes values aren't the same as the Readiness:

  • The title suggests "values"
  • The text body speaks about "endpoint":

When Liveness and Readiness probes are pointing to the same endpoint, the effects of the probes are combined.

I think the title is correct, and the task body should be updated to reflect that it's generally fine to have the same endpoint called from liveness and readiness probes, as long as the values are different (and those for liveness are more tolerant than those for readiness).

Referenced article Liveness probes are dangerous:

if you use Liveness Probe, don’t set the same specification for Liveness and Readiness Probe

  • you can use a Liveness Probe with the same health check, but a higher failureThreshold (e.g. mark as not-ready after 3 attempts and fail Liveness Probe after 10 attempts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant