Add methods for the borehole #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to check if a point is inside the HPGe borehole, this is useful for primary generation and for post processing.
It did reveal however that some of the geometry methods for signed distances are a bit unstable... this should handle the case of convex corners in the geometry (< 90 deg), but not the case of concave (< 90 deg).
We should maybe add these checks in future and try to make all this geometry code more robust (@ggmarshall ?)