Skip to content

Add methods for the borehole #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2025
Merged

Add methods for the borehole #78

merged 9 commits into from
Jul 18, 2025

Conversation

tdixon97
Copy link
Contributor

This adds a function to check if a point is inside the HPGe borehole, this is useful for primary generation and for post processing.
It did reveal however that some of the geometry methods for signed distances are a bit unstable... this should handle the case of convex corners in the geometry (< 90 deg), but not the case of concave (< 90 deg).

We should maybe add these checks in future and try to make all this geometry code more robust (@ggmarshall ?)

@ManuelHu
Copy link
Contributor

we did not require awkward in this package before

Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 75.55556% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.96%. Comparing base (13f0047) to head (6a7fc4a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/legendhpges/invcoax.py 79.06% 9 Missing ⚠️
src/legendhpges/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   69.59%   69.96%   +0.37%     
==========================================
  Files          15       15              
  Lines         865      909      +44     
==========================================
+ Hits          602      636      +34     
- Misses        263      273      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManuelHu ManuelHu merged commit 124b557 into legend-exp:main Jul 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants