Minor edits

Author: leo-arch

src/init.c

@@ -2752,6 +2752,15 @@ set_encoded_prompt(void)
 	}
 }
 
+static char *
+set_warning_prompt_str(void)
+{
+	return (conf.colorize == 1
+		? savestring(DEF_WPROMPT_STR, sizeof(DEF_WPROMPT_STR) - 1)
+		: savestring(DEF_WPROMPT_STR_NO_COLOR,
+				sizeof(DEF_WPROMPT_STR_NO_COLOR) - 1));
+}
+
 #define SETOPT(cmd_line, def) ((cmd_line) == UNSET ? (def) : (cmd_line))
 
 /* If some option was not set, set it to the default value. */
@@ -3004,13 +3013,8 @@ check_options(void)
 
 	set_prompt_options();
 
-	if (!conf.wprompt_str) {
-		if (conf.colorize == 1)
-			conf.wprompt_str = savestring(DEF_WPROMPT_STR, sizeof(DEF_WPROMPT_STR) - 1);
-		else
-			conf.wprompt_str = savestring(DEF_WPROMPT_STR_NO_COLOR,
-				sizeof(DEF_WPROMPT_STR_NO_COLOR) - 1);
-	}
+	if (!conf.wprompt_str)
+		conf.wprompt_str = set_warning_prompt_str();
 
 	if ((xargs.stealth_mode == 1 || home_ok == 0 ||
 	config_ok == 0 || !config_file) && !*div_line) {

src/keybinds.c

@@ -2775,7 +2775,7 @@ rl_switch_workspace(const int n)
 	if (rl_line_buffer && *rl_line_buffer)
 		rl_delete_text(0, rl_end);
 
-	char t[16];
+	char t[MAX_INT_STR + 4];
 	exec_prompt_cmds = 1;
 
 	if (cur_ws == (n - 1)) {

src/misc.c

@@ -1861,11 +1861,10 @@ handle_stdin(void)
 	 * == (65535 * PATH_MAX)
 	 * == 262MiB of data ((65535 * PATH_MAX) / 1024). */
 
-	size_t chunk = (size_t)512 * 1024;
+	const size_t chunk = (size_t)512 * 1024;
+	const size_t max_chunks = 512;
 	size_t chunks_n = 1;
 	size_t total_len = 0;
-	size_t max_chunks = 512;
-
 	ssize_t input_len = 0;
 
 	/* Initial buffer allocation == 1 chunk */

src/sanitize.c

@@ -161,7 +161,7 @@ sanitize_shell_level(char *str)
 	if (!str || !*str || !is_number(str))
 		return FUNC_FAILURE;
 
-	int a = atoi(str);
+	const int a = atoi(str);
 	if (a < 1 || a > MAX_SHELL_LEVEL)
 		return FUNC_FAILURE;
 
@@ -172,10 +172,10 @@ sanitize_shell_level(char *str)
 static void
 drop_privs(void)
 {
-	uid_t ruid = getuid();
-	uid_t euid = geteuid();
-	gid_t rgid = getgid();
-	gid_t egid = getegid();
+	const uid_t ruid = getuid();
+	const uid_t euid = geteuid();
+	const gid_t rgid = getgid();
+	const gid_t egid = getegid();
 
 	if (rgid != egid) {
 		int err = 0;

src/sort.c

@@ -359,12 +359,6 @@ print_sort_method(void)
 		putchar('\n');
 }
 
-static inline void
-toggle_sort_reverse(void)
-{
-	conf.sort_reverse = !conf.sort_reverse;
-}
-
 static inline int
 re_sort_files_list(void)
 {
@@ -421,7 +415,7 @@ sort_function(char **arg)
 	/* Argument is an alphanumerical string */
 	if (!is_number(arg[1])) {
 		if (*arg[1] == 'r' && strcmp(arg[1], "rev") == 0) {
-			toggle_sort_reverse();
+			conf.sort_reverse = !conf.sort_reverse;
 			return re_sort_files_list();
 		}
 
@@ -449,7 +443,7 @@ sort_function(char **arg)
 		conf.sort = n;
 
 		if (arg[2] && *arg[2] == 'r' && strcmp(arg[2], "rev") == 0)
-			toggle_sort_reverse();
+			conf.sort_reverse = !conf.sort_reverse;
 
 		update_autocmd_opts(AC_SORT);