removed unnecessary methods

Author: kroitor

js/src/base/Exchange.js

@@ -550,31 +550,6 @@ export default class Exchange {
     throttle(cost = undefined) {
         return this.throttler.throttle(cost);
     }
-    setSandboxMode(enabled) {
-        if (!!enabled) { // eslint-disable-line no-extra-boolean-cast
-            if ('test' in this.urls) {
-                if (typeof this.urls['api'] === 'string') {
-                    this.urls['apiBackup'] = this.urls['api'];
-                    this.urls['api'] = this.urls['test'];
-                }
-                else {
-                    this.urls['apiBackup'] = clone(this.urls['api']);
-                    this.urls['api'] = clone(this.urls['test']);
-                }
-            }
-            else {
-                throw new NotSupported(this.id + ' does not have a sandbox URL');
-            }
-        }
-        else if ('apiBackup' in this.urls) {
-            if (typeof this.urls['api'] === 'string') {
-                this.urls['api'] = this.urls['apiBackup'];
-            }
-            else {
-                this.urls['api'] = clone(this.urls['apiBackup']);
-            }
-        }
-    }
     defineRestApiEndpoint(methodName, uppercaseMethod, lowercaseMethod, camelcaseMethod, path, paths, config = {}) {
         const splitPath = path.split(/[^a-zA-Z0-9]/);
         const camelcaseSuffix = splitPath.map(this.capitalize).join('');
@@ -1263,6 +1238,33 @@ export default class Exchange {
         }
         return this.filterByLimit(result, limit, key);
     }
+    setSandboxMode(enabled) {
+        if (enabled) {
+            if ('test' in this.urls) {
+                if (typeof this.urls['api'] === 'string') {
+                    this.urls['apiBackup'] = this.urls['api'];
+                    this.urls['api'] = this.urls['test'];
+                }
+                else {
+                    this.urls['apiBackup'] = this.clone(this.urls['api']);
+                    this.urls['api'] = this.clone(this.urls['test']);
+                }
+            }
+            else {
+                throw new NotSupported(this.id + ' does not have a sandbox URL');
+            }
+        }
+        else if ('apiBackup' in this.urls) {
+            if (typeof this.urls['api'] === 'string') {
+                this.urls['api'] = this.urls['apiBackup'];
+            }
+            else {
+                this.urls['api'] = this.clone(this.urls['apiBackup']);
+            }
+            const newUrls = this.omit(this.urls, 'apiBackup');
+            this.urls = newUrls;
+        }
+    }
     sign(path, api = 'public', method = 'GET', params = {}, headers = undefined, body = undefined) {
         return {};
     }

php/Exchange.php

@@ -1624,13 +1624,13 @@ def find_timeframe(self, timeframe, timeframes=None):
     def clone(self, obj):
         return obj if isinstance(obj, list) else self.extend(obj)
 
-    def deleteKeyFromDictionary (self, dictionary, key):
-        newDictionary = self.clone(dictionary)
-        del newDictionary[key]
-        return newDictionary
+    # def delete_key_from_dictionary(self, dictionary, key):
+    #     newDictionary = self.clone(dictionary)
+    #     del newDictionary[key]
+    #     return newDictionary
 
-    def setObjectProperty (obj, prop, value):
-        obj[prop] = value
+    # def set_object_property(obj, prop, value):
+    #     obj[prop] = value
 
     def convert_to_big_int(self, value):
         return int(value) if isinstance(value, str) else value
@@ -1788,6 +1788,25 @@ def filter_by_value_since_limit(self, array: List[object], field: IndexType, val
             return result[-limit:]
         return self.filter_by_limit(result, limit, key)
 
+    def set_sandbox_mode(self, enabled):
+        if enabled:
+            if 'test' in self.urls:
+                if isinstance(self.urls['api'], str):
+                    self.urls['apiBackup'] = self.urls['api']
+                    self.urls['api'] = self.urls['test']
+                else:
+                    self.urls['apiBackup'] = self.clone(self.urls['api'])
+                    self.urls['api'] = self.clone(self.urls['test'])
+            else:
+                raise NotSupported(self.id + ' does not have a sandbox URL')
+        elif 'apiBackup' in self.urls:
+            if isinstance(self.urls['api'], str):
+                self.urls['api'] = self.urls['apiBackup']
+            else:
+                self.urls['api'] = self.clone(self.urls['apiBackup'])
+            newUrls = self.omit(self.urls, 'apiBackup')
+            self.urls = newUrls
+
     def sign(self, path, api: Any = 'public', method='GET', params={}, headers: Optional[Any] = None, body: Optional[Any] = None):
         return {}
 

python/ccxt/base/exchange.py

@@ -124,7 +124,7 @@ const {
     , NetworkError
     , ExchangeNotAvailable
     , ArgumentsRequired
-    , RateLimitExceeded, 
+    , RateLimitExceeded,
     BadRequest} from "./errors.js"
 
 import { Precise } from './Precise.js'
@@ -875,7 +875,7 @@ export default class Exchange {
                 // @ts-ignore
                 module = await import (/* webpackIgnore: true */ 'socks-proxy-agent');
             } catch (e) {
-                throw new NotSupported (this.id + ' - to use SOCKS proxy with ccxt, at first you need install module "npm i socks-proxy-agent" '); 
+                throw new NotSupported (this.id + ' - to use SOCKS proxy with ccxt, at first you need install module "npm i socks-proxy-agent" ');
             }
             this.agent = new module.SocksProxyAgent(socksProxy);
         }
@@ -1315,16 +1315,6 @@ export default class Exchange {
         return -1;
     }
 
-    deleteKeyFromDictionary (dictionary, key) {
-        const newDictionary = this.clone (dictionary);
-        delete newDictionary[key];
-        return newDictionary;
-    }
-
-    setObjectProperty (obj, prop, value) {
-        obj[prop] = value;
-    }
-
     convertToBigInt(value: string) {
         return BigInt(value); // used on XT
     }
@@ -1543,8 +1533,8 @@ export default class Exchange {
             } else {
                 this.urls['api'] = this.clone (this.urls['apiBackup']);
             }
-            const newUrls = this.deleteKeyFromDictionary (this.urls, 'apiBackup');
-            this.setObjectProperty (this, 'urls', newUrls);
+            const newUrls = this.omit (this.urls, 'apiBackup');
+            this.urls = newUrls;
         }
     }