isANSISupported returns false on empty term

Author: lfir

src/main/java/cf/maybelambda/fedora/ConsoleIOHelper.java

@@ -68,6 +68,6 @@ static String color(String str, String ansiColorCode) {
     }
 
     static boolean isANSISupported(String term, Console console) {
-        return console != null && term != null && !"dumb".equals(term);
+        return console != null && term != null && !term.isEmpty() && !"dumb".equals(term);
     }
 }

src/test/java/cf/maybelambda/fedora/ConsoleIOHelperTests.java

@@ -131,24 +131,23 @@ void colorReturnsPlainTextWhenisANSISupportedFalse() {
         }
     }
 
-    @Test
-    void isANSISupportedReturnsTrueWhenConsolePresentAndTermValid() {
-        assertTrue(isANSISupported("xterm-256color", mock(Console.class)));
-    }
-
-    @Test
-    void isANSISupportedReturnsFalseWhenConsoleIsNull() {
-        assertFalse(isANSISupported("xterm-256color", null));
-    }
-
-    @Test
-    void isANSISupportedReturnsFalseWhenTermIsNull() {
-        assertFalse(isANSISupported(null, mock(Console.class)));
+    @ParameterizedTest
+    @ValueSource(strings = {
+        "xterm-256color",
+        "xterm",
+        "screen",
+    })
+    void isANSISupportedReturnsTrueWhenConsolePresentAndTermValid(String term) {
+        assertTrue(isANSISupported(term, mock(Console.class)));
     }
 
     @Test
-    void isANSISupportedReturnsFalseWhenTermIsDumb() {
+    void isANSISupportedReturnsFalseWhenTermOrConsoleInvalid() {
+        assertFalse(isANSISupported("", mock(Console.class)));
         assertFalse(isANSISupported("dumb", mock(Console.class)));
+        assertFalse(isANSISupported("xterm", null));
+        assertFalse(isANSISupported(null, mock(Console.class)));
+        assertFalse(isANSISupported(null, null));
     }
 
     @Test