Remove deprecated methods at compile time

libmesh_deprecated() is sometimes necessary, when one possible input is
deprecated but another supported, but if *any* call to a method is
deprecated we can just get rid of it completely in
`--disable-deprecated` builds.

Author: roystgnr

include/base/dof_object.h

@@ -181,12 +181,14 @@ class DofObject : public ReferenceCountedObject<DofObject>
    */
   unique_id_type unique_id () const;
 
+#ifdef LIBMESH_ENABLE_DEPRECATED
   /**
    * \returns The globally \p unique_id for this \p DofObject as a
    * writable reference.  Deprecated; use the API taking an input
    * instead.
    */
   unique_id_type & set_unique_id ();
+#endif // LIBMESH_ENABLE_DEPRECATED
 
   /**
    * Sets the \p unique_id for this \p DofObject
@@ -851,6 +853,7 @@ unique_id_type DofObject::unique_id () const
 
 
 
+#ifdef LIBMESH_ENABLE_DEPRECATED
 inline
 unique_id_type & DofObject::set_unique_id ()
 {
@@ -861,6 +864,7 @@ unique_id_type & DofObject::set_unique_id ()
   libmesh_not_implemented();
 #endif
 }
+#endif // LIBMESH_ENABLE_DEPRECATED
 
 
 

include/fe/fe_abstract.h

@@ -201,20 +201,23 @@ class FEAbstract : public ReferenceCountedObject<FEAbstract>
                          const std::vector<Point> & reference_side_points,
                          std::vector<Point> &       reference_points) = 0;
 
+#ifdef LIBMESH_ENABLE_DEPRECATED
   /**
    * \returns \p true if the point p is located on the reference element
    * for element type t, false otherwise.  Since we are doing floating
    * point comparisons here the parameter \p eps can be specified to
    * indicate a tolerance.  For example, \f$ x \le 1 \f$  becomes
    * \f$ x \le 1 + \epsilon \f$.
    *
-   * This method overload does not support all finite element types;
-   * e.g. the Polygon1 type may differ from element to element.  Use
-   * \p Elem::on_reference_element() instead.
+   * This method overload is now deprecated, since it cannot support
+   * all finite element types; e.g. the Polygon1 type may differ from
+   * element to element.  Use \p Elem::on_reference_element() instead.
    */
   static bool on_reference_element(const Point & p,
                                    const ElemType t,
                                    const Real eps = TOLERANCE);
+#endif // LIBMESH_ENABLE_DEPRECATED
+
   /**
    * \returns The reference space coordinates of \p nodes based on the
    * element type.