Rem data_slice chain cons in favor of stream::in::fast&& overrides.

evoskuil · evoskuil · commit 7ebb4da003b9 · 2025-04-13T18:31:56.000-04:00
diff --git a/include/bitcoin/system/chain/block.hpp b/include/bitcoin/system/chain/block.hpp
@@ -55,7 +55,6 @@ class BC_API block
     block(const chain::header::cptr& header,
         const transactions_cptr& txs) NOEXCEPT;
 
-    block(const data_slice& data, bool witness) NOEXCEPT;
     block(stream::in::fast&& stream, bool witness) NOEXCEPT;
     block(stream::in::fast& stream, bool witness) NOEXCEPT;
     block(std::istream&& stream, bool witness) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/header.hpp b/include/bitcoin/system/chain/header.hpp
@@ -66,7 +66,6 @@ class BC_API header
         const hash_digest& merkle_root, uint32_t timestamp, uint32_t bits,
         uint32_t nonce) NOEXCEPT;
 
-    header(const data_slice& data) NOEXCEPT;
     header(stream::in::fast&& stream) NOEXCEPT;
     header(stream::in::fast& stream) NOEXCEPT;
     header(std::istream&& stream) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/input.hpp b/include/bitcoin/system/chain/input.hpp
@@ -68,7 +68,6 @@ class BC_API input
     input(const chain::point::cptr& point, const chain::script::cptr& script,
         const chain::witness::cptr& witness, uint32_t sequence) NOEXCEPT;
 
-    input(const data_slice& data) NOEXCEPT;
     input(stream::in::fast&& stream) NOEXCEPT;
     input(stream::in::fast& stream) NOEXCEPT;
     input(std::istream&& stream) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/operation.hpp b/include/bitcoin/system/chain/operation.hpp
@@ -84,7 +84,6 @@ class BC_API operation
     operation(const chunk_cptr& push_data, bool minimal) NOEXCEPT;
 
     /// These deserialize operations (with codes), not from push-data.
-    operation(const data_slice& op_data) NOEXCEPT;
     operation(stream::in::fast&& stream) NOEXCEPT;
     operation(stream::in::fast& stream) NOEXCEPT;
     operation(std::istream&& stream) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/output.hpp b/include/bitcoin/system/chain/output.hpp
@@ -50,7 +50,6 @@ class BC_API output
     output(uint64_t value, const chain::script& script) NOEXCEPT;
     output(uint64_t value, const chain::script::cptr& script) NOEXCEPT;
 
-    output(const data_slice& data) NOEXCEPT;
     output(stream::in::fast&& stream) NOEXCEPT;
     output(stream::in::fast& stream) NOEXCEPT;
     output(std::istream&& stream) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/point.hpp b/include/bitcoin/system/chain/point.hpp
@@ -57,7 +57,6 @@ class BC_API point
     point(hash_digest&& hash, uint32_t index) NOEXCEPT;
     point(const hash_digest& hash, uint32_t index) NOEXCEPT;
 
-    point(const data_slice& data) NOEXCEPT;
     point(stream::in::fast&& stream) NOEXCEPT;
     point(stream::in::fast& stream) NOEXCEPT;
     point(std::istream&& stream) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/script.hpp b/include/bitcoin/system/chain/script.hpp
@@ -102,7 +102,7 @@ class BC_API script
     script(const operations& ops) NOEXCEPT;
     script(operations&& ops, bool prefail) NOEXCEPT;
     script(const operations& ops, bool prefail) NOEXCEPT;
-    script(const data_slice& data, bool prefix) NOEXCEPT;
+
     script(stream::in::fast&& stream, bool prefix) NOEXCEPT;
     script(stream::in::fast& stream, bool prefix) NOEXCEPT;
     script(std::istream&& stream, bool prefix) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/transaction.hpp b/include/bitcoin/system/chain/transaction.hpp
@@ -69,8 +69,7 @@ class BC_API transaction
         const chain::outputs& outputs, uint32_t locktime) NOEXCEPT;
     transaction(uint32_t version, const inputs_cptr& inputs,
         const outputs_cptr& outputs, uint32_t locktime) NOEXCEPT;
-    
-    transaction(const data_slice& data, bool witness) NOEXCEPT;
+
     transaction(stream::in::fast&& stream, bool witness) NOEXCEPT;
     transaction(stream::in::fast& stream, bool witness) NOEXCEPT;
     transaction(std::istream&& stream, bool witness) NOEXCEPT;
diff --git a/include/bitcoin/system/chain/witness.hpp b/include/bitcoin/system/chain/witness.hpp
@@ -55,7 +55,6 @@ class BC_API witness
     witness(chunk_cptrs&& stack) NOEXCEPT;
     witness(const chunk_cptrs& stack) NOEXCEPT;
 
-    witness(const data_slice& data, bool prefix) NOEXCEPT;
     witness(stream::in::fast&& stream, bool prefix) NOEXCEPT;
     witness(stream::in::fast& stream, bool prefix) NOEXCEPT;
     witness(std::istream&& stream, bool prefix) NOEXCEPT;
diff --git a/src/chain/block.cpp b/src/chain/block.cpp
@@ -72,11 +72,6 @@ block::block(const chain::header::cptr& header,
 {
 }
 
-block::block(const data_slice& data, bool witness) NOEXCEPT
-  : block(stream::in::fast(data), witness)
-{
-}
-
 block::block(stream::in::fast&& stream, bool witness) NOEXCEPT
   : block(read::bytes::fast(stream), witness)
 {
diff --git a/src/chain/header.cpp b/src/chain/header.cpp
@@ -59,13 +59,6 @@ header::header(uint32_t version, const hash_digest& previous_block_hash,
 {
 }
 
-header::header(const data_slice& data) NOEXCEPT
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-  : header(stream::in::copy(data))
-    BC_POP_WARNING()
-{
-}
-
 header::header(stream::in::fast&& stream) NOEXCEPT
   : header(read::bytes::fast(stream))
 {
diff --git a/src/chain/input.cpp b/src/chain/input.cpp
@@ -144,11 +144,6 @@ input::input(const chain::point::cptr& point, const chain::script::cptr& script,
 {
 }
 
-input::input(const data_slice& data) NOEXCEPT
-  : input(stream::in::copy(data))
-{
-}
-
 input::input(stream::in::fast&& stream) NOEXCEPT
   : input(read::bytes::fast(stream))
 {
diff --git a/src/chain/operation.cpp b/src/chain/operation.cpp
@@ -123,13 +123,6 @@ operation::operation(const chunk_cptr& push_data, bool minimal) NOEXCEPT
 {
 }
 
-operation::operation(const data_slice& op_data) NOEXCEPT
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-  : operation(stream::in::copy(op_data))
-    BC_POP_WARNING()
-{
-}
-
 operation::operation(stream::in::fast&& stream) NOEXCEPT
   : operation(read::bytes::fast(stream))
 {
diff --git a/src/chain/output.cpp b/src/chain/output.cpp
@@ -60,11 +60,6 @@ output::output(uint64_t value, const chain::script::cptr& script) NOEXCEPT
 {
 }
 
-output::output(const data_slice& data) NOEXCEPT
-  : output(stream::in::copy(data))
-{
-}
-
 output::output(stream::in::fast&& stream) NOEXCEPT
   : output(read::bytes::fast(stream))
 {
diff --git a/src/chain/point.cpp b/src/chain/point.cpp
@@ -50,13 +50,6 @@ point::point(const hash_digest& hash, uint32_t index) NOEXCEPT
 {
 }
 
-point::point(const data_slice& data) NOEXCEPT
-    BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
-  : point(stream::in::copy(data))
-    BC_POP_WARNING()
-{
-}
-
 point::point(stream::in::fast&& stream) NOEXCEPT
   : point(read::bytes::fast(stream))
 {
diff --git a/src/chain/script.cpp b/src/chain/script.cpp
@@ -111,11 +111,6 @@ script::script(const operations& ops, bool prefail) NOEXCEPT
 {
 }
 
-script::script(const data_slice& data, bool prefix) NOEXCEPT
-  : script(stream::in::copy(data), prefix)
-{
-}
-
 script::script(stream::in::fast&& stream, bool prefix) NOEXCEPT
   : script(read::bytes::fast(stream), prefix)
 {
diff --git a/src/chain/transaction.cpp b/src/chain/transaction.cpp
@@ -98,11 +98,6 @@ transaction::transaction(uint32_t version, const inputs_cptr& inputs,
 {
 }
 
-transaction::transaction(const data_slice& data, bool witness) NOEXCEPT
-  : transaction(stream::in::copy(data), witness)
-{
-}
-
 transaction::transaction(stream::in::fast&& stream, bool witness) NOEXCEPT
   : transaction(read::bytes::fast(stream), witness)
 {
diff --git a/src/chain/witness.cpp b/src/chain/witness.cpp
@@ -72,11 +72,6 @@ witness::witness(const chunk_cptrs& stack) NOEXCEPT
 {
 }
 
-witness::witness(const data_slice& data, bool prefix) NOEXCEPT
-  : witness(stream::in::copy(data), prefix)
-{
-}
-
 witness::witness(stream::in::fast&& stream, bool prefix) NOEXCEPT
   : witness(read::bytes::fast(stream), prefix)
 {

Original file line number	Diff line number	Diff line change
`@@ -72,11 +72,6 @@ block::block(const chain::header::cptr& header,`
`72`	`72`	`{`
`73`	`73`	`}`
`74`	`74`
`75`		`-block::block(const data_slice& data, bool witness) NOEXCEPT`
`76`		`- : block(stream::in::fast(data), witness)`
`77`		`-{`
`78`		`-}`
`79`		`-`
`80`	`75`	`block::block(stream::in::fast&& stream, bool witness) NOEXCEPT`
`81`	`76`	`: block(read::bytes::fast(stream), witness)`
`82`	`77`	`{`