Old TODOs tracker

[drHuangMHT]

Below are TODOs that were created at least 4 years ago:

• rust-libp2p/core/src/transport/timeout.rs

  Lines 150 to 151 in 7eeb144

  	// TODO: can be replaced with `impl Future` once `impl Trait` are fully stable in Rust
  	// (https://github.com/rust-lang/rust/issues/34511)

  • Tracking issue for impl Trait (RFC 1522, RFC 1951, RFC 2071) rust-lang/rust#34511 has been replaced with Meta tracking issue for impl Trait rust-lang/rust#63066

• rust-libp2p/core/src/upgrade/transfer.rs

  Lines 93 to 94 in 7eeb144

  	// TODO: why do we have a `__Nonexhaustive` variant in the error? I don't know how to process it
  	// Err(unsigned_varint::decode::Error::Insufficient) => {}

• rust-libp2p/core/src/upgrade/transfer.rs

  Line 149 in 7eeb144

  // TODO: rewrite these tests

• rust-libp2p/misc/multistream-select/src/dialer_select.rs

  Lines 70 to 72 in 7eeb144

  	pub struct DialerSelectFuture<R, I: Iterator> {
  	// TODO: It would be nice if eventually N = I::Item = Protocol.
  	protocols: iter::Peekable<I>,

• rust-libp2p/misc/multistream-select/src/listener_select.rs

  Lines 75 to 78 in 7eeb144

  	pub struct ListenerSelectFuture<R, N> {
  	// TODO: It would be nice if eventually N = Protocol, which has a
  	// few more implications on the API.
  	protocols: SmallVec<[(N, Protocol); 8]>,

• rust-libp2p/protocols/floodsub/src/layer.rs

  Lines 52 to 55 in 7eeb144

  	/// List of peers the network is connected to, and the topics that they're subscribed to.
  	// TODO: filter out peers that don't support floodsub, so that we avoid hammering them with
  	// opened substreams
  	connected_peers: HashMap<PeerId, SmallVec<[Topic; 8]>>,

• rust-libp2p/protocols/kad/src/behaviour.rs

  Lines 2397 to 2401 in 7eeb144

  	// TODO: AddProvider requests yield no response, so the query completes
  	// as soon as all requests have been sent. However, the handler should
  	// better emit an event when the request has been sent (and report
  	// an error if sending fails), instead of immediately reporting
  	// "success" somewhat prematurely here.

• rust-libp2p/protocols/kad/src/handler.rs

  Lines 122 to 124 in 7eeb144

  	/// Waiting for an answer back from the remote.
  	// TODO: add timeout
  	WaitingAnswer(KadOutStreamSink<Stream>, QueryId),

• rust-libp2p/protocols/kad/src/handler.rs

  Lines 1133 to 1135 in 7eeb144

  	/// Process a Kademlia message that's supposed to be a response to one of our requests.
  	fn process_kad_response(event: KadResponseMsg, query_id: QueryId) -> KademliaHandlerEvent {
  	// TODO: must check that the response corresponds to the request

• rust-libp2p/protocols/kad/src/protocol.rs

  Lines 101 to 103 in 7eeb144

  	fn try_from(peer: proto::Peer) -> Result<KadPeer, Self::Error> {
  	// TODO: this is in fact a CID; not sure if this should be handled in `from_bytes` or
  	// as a special case here

• rust-libp2p/protocols/kad/src/protocol.rs

  Lines 136 to 138 in 7eeb144

  	// TODO: if, as suspected, we can confirm with Protocol Labs that each open Kademlia substream does
  	// only one request, then we can change the output of the `InboundUpgrade` and
  	// `OutboundUpgrade` to be just a single message

• rust-libp2p/protocols/kad/src/protocol.rs

  Lines 454 to 456 in 7eeb144

  	// TODO: for now we don't parse the peer properly, so it is possible that we get
  	// parsing errors for peers even when they are valid; we ignore these
  	// errors for now, but ultimately we should just error altogether

• rust-libp2p/protocols/kad/src/protocol.rs

  Line 624 in 7eeb144

  /*// TODO: restore

• rust-libp2p/protocols/kad/src/lib.rs

  Lines 36 to 37 in 7eeb144

  	// TODO: we allow dead_code for now because this library contains a lot of unused code that will
  	// be useful later for record store

• rust-libp2p/protocols/kad/src/behaviour/test.rs

  Lines 806 to 807 in 7eeb144

  	// TODO: Randomise
  	let num_nodes = 12;

• rust-libp2p/protocols/mdns/src/behaviour/iface/dns.rs

  Line 52 in 7eeb144

  // TODO: better error type?

• rust-libp2p/protocols/mdns/src/behaviour/iface/dns.rs

  Line 67 in 7eeb144

  // TODO: remove the backslashes if any

• rust-libp2p/protocols/mdns/src/behaviour/iface/dns.rs

  Line 438 in 7eeb144

  // TODO: test limits and errors

• rust-libp2p/swarm/src/lib.rs

  Line 1330 in 7eeb144

  // TODO: #[derive(Debug)]

• rust-libp2p/swarm/src/handler/one_shot.rs

  Line 32 in 7eeb144

  // TODO: Debug

• rust-libp2p/swarm/tests/swarm_derive.rs

  Line 35 in 7eeb144

  // TODO: doesn't compile

• rust-libp2p/transports/uds/src/lib.rs

  Line 327 in 7eeb144

  #[ignore] // TODO: for the moment unix addresses fail to parse

  rust-libp2p/transports/uds/src/lib.rs

  Line 336 in 7eeb144

  #[ignore] // TODO: for the moment unix addresses fail to parse

[thomaseizinger]

Awesome! Thank you for doing this!

Would you mind linking to the code directly to make the discussion easier?

[thomaseizinger]

Thank you for tracking these! Sorry for the late response, this kind of fell-through.

Would you be interested in tackling some of these? I think any form of commented out code can simply be deleted. If we didn't need it in 4 years, we don't need it now :D

Any comment in the form of "it would be nice if" can also be deleted.