-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea/Proposal: Loudness normalization #101
Comments
Comment by cortegedusage hmm this sounds interesting, although I'm not a programmer but merely an enthusiast. I'm wondering how Btw. Is there any light on a new owner for librespot, because good things anyways, we'll see. 2018-01-06 13:26 GMT+01:00 herrernst [email protected]:
|
Comment by herrernst Are you really sure that Spotify applies compression? Do you have any references on that? |
Comment by cortegedusage Not on any spotify documentation, but here is what I came up with http://productionadvice.co.uk/spotify-same-volume-setting/ hmmm and ofcourse I also find a post claiming the opposite... but reading this: I come to think they might do both. anyway. these are my five cents. 2018-01-07 22:11 GMT+01:00 herrernst [email protected]:
|
Comment by cortegedusage remaining question is, how does your implementation sound like. And this might be something I can imagine users would like to have (I would) So is it actually doing what it should do? normalizing the volume? and as I don't have a development setup would you mind sharing a binairy as thanks 2018-01-07 22:36 GMT+01:00 Dennis van Paassen [email protected]:
|
Comment by herrernst I just apply the replaygain factor, so it doesn't sound special, everything else (i.e. implementing a compressor/limiter) would be nontrivial |
Comment by kingosticks @herrernst, out of interest, how did you discover where to find the values? Any ideas what goodies lay between bytes 160 and 167? |
Comment by herrernst @kingosticks https://sourceforge.net/p/despotify/code/HEAD/tree/java/trunk/src/main/java/se/despotify/client/player/SpotifyOggHeader.java#l106 |
Comment by cortegedusage @herrernst https://open.spotify.com/track/0CQMJlkWMcpiqyplxaYPH9?si=-x6V8wzXQWW3SB3h2Teb5w is it just me? or are you also hearing this? |
Comment by herrernst @cortegedusage thanks for your report. That is indeed a problem, that song is very quiet, and will be boosted which probably results in clipping. I will take a look at it hopefully sometime ... |
Please see #15 for continued discussion. |
Issue by herrernst
Saturday Jan 06, 2018 at 12:26 GMT
Originally opened as plietar/librespot#270
(I know this project is not really maintained anymore, but I wanted to document this in case if anyone is interested.)
The official Spotify clients have an option (enabled by default) to normalize volume, which adjust the volume of differently mastered songs to sound equally loud (see https://en.wikipedia.org/wiki/Audio_normalization). This is primarily important when playing playlists.
Some pre-computed compensation values are stored in the proprietary ogg header (as 32 LE floats, starting at offset 144). I have a branch which reads these values and applies the first (I don't yet know what the others are good for) if librespot is started with
--enable-volume-normalization
: https://github.com/herrernst/librespot/tree/volume-normalization The resulting level still different from the Spotify client though.The text was updated successfully, but these errors were encountered: