Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on some songs #87

Closed
sashahilton00 opened this issue Jan 29, 2018 · 10 comments
Closed

Crash on some songs #87

sashahilton00 opened this issue Jan 29, 2018 · 10 comments

Comments

@sashahilton00
Copy link
Member

Issue by Glenn-1990
Tuesday Sep 05, 2017 at 18:53 GMT
Originally opened as plietar/librespot#247


Librespot crashes on some songs, this is 100% reproducible (pi musicbox and libreelec).
The song causing the crash is not working with chromecast either, so probably spotify doesn't allow to play this song externally. It would be nice if we could just skip this song instead of the assertion :-).

Sep 04 21:12:24 LE-glenn sh[2943]: thread 'main' panicked at 'assertion failed: (left == right) (left: 0, right: 16)', util/spotify_id.rs:44
Sep 04 21:12:24 LE-glenn sh[2943]: note: Run with RUST_BACKTRACE=1 for a backtrace.
Sep 04 21:12:24 LE-glenn systemd[1]: service.librespot.service: Main process exited, code=exited, status=101/n/a
Sep 04 21:12:24 LE-glenn systemd[1]: service.librespot.service: Unit entered failed state.
Sep 04 21:12:24 LE-glenn systemd[1]: service.librespot.service: Failed with result 'exit-code'.

@sashahilton00
Copy link
Member Author

Comment by michaelherger
Wednesday Sep 06, 2017 at 03:57 GMT


It would probably be helpful if you could give some track IDs causing this.

@sashahilton00
Copy link
Member Author

Comment by Glenn-1990
Monday Sep 18, 2017 at 17:57 GMT


@michaelherger
How can I find these IDs as parsing fails?

@sashahilton00
Copy link
Member Author

Comment by michaelherger
Tuesday Sep 19, 2017 at 05:35 GMT


In the Spotify applications there's a "..." menu item which allows you to copy the item's URI.

@sashahilton00
Copy link
Member Author

Comment by Glenn-1990
Tuesday Sep 19, 2017 at 17:41 GMT


Something strange is going on here, spotify doesn't have URLs for the crashing songs.

"Delen" = "Share" and allows me to get the URL.

Normal song:
screenshot_20170919-192934

Crashing song:
screenshot_20170919-192945

@sashahilton00
Copy link
Member Author

Comment by cortegedusage
Tuesday Sep 19, 2017 at 18:32 GMT


It looks like the song in the playlist is refering to a song on an album
that doesn't exists anymore on spotify

probably the spotify software searches for an alternative and librespot
doesn't.

that's my five cents anyway...

cheers

2017-09-19 19:41 GMT+02:00 Glenn-1990 [email protected]:

Something strange is going on here, spotify doesn't have URLs for the
crashing songs.

"Delen" = "Share" and allows me to get the URL.

Normal song:
[image: screenshot_20170919-192934]
https://user-images.githubusercontent.com/2036512/30606419-fa04cd7c-9d71-11e7-9e70-806cfd260d29.png

Crashing song:
[image: screenshot_20170919-192945]
https://user-images.githubusercontent.com/2036512/30606381-da5f73dc-9d71-11e7-947a-bdd54ca8f9bd.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
plietar/librespot#247 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV69TZgYWAivU2k2Lw8xHNyyedUyRPLeks5sj_zHgaJpZM4PNXp-
.

@sashahilton00
Copy link
Member Author

Comment by archi
Friday Dec 22, 2017 at 16:11 GMT


I hit the same, seems a lot like what you suggested.
Since librespot is not maintained anymore I suppose it's just tough luck :(

@sashahilton00
Copy link
Member Author

Comment by kingosticks
Friday Dec 22, 2017 at 16:47 GMT


But it does look like it tries to: https://github.com/plietar/librespot/blob/ddfc28f99f283caa81951c63dd03fa913af1b8de/src/player.rs#L351

@sashahilton00
Copy link
Member Author

Comment by kingosticks
Friday Dec 22, 2017 at 18:59 GMT


An example of a failing song would be helpful.

@sashahilton00
Copy link
Member Author

Comment by moses-palmer
Wednesday Jan 03, 2018 at 14:08 GMT


To reproduce, you can create a playlist on Spotify desktop, add a local directory and then add a local song to the playlist. When librespot then tries to play that song, this assertion will fail since it does not correspond to a song available on Spotify.

@ComlOnline ComlOnline added the bug label Jan 29, 2018
@sashahilton00
Copy link
Member Author

Since this issue has no backtrace, no sample songs to reproduce, and no further reports within the past couple of months, I'm closing this. Please reopen with a backtrace and sample songs if this error still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants