Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sony PlayStation Controllers: Device Index mislabeling in Flatpak #16868

Closed
davidhedlund opened this issue Aug 11, 2024 · 9 comments
Closed

Sony PlayStation Controllers: Device Index mislabeling in Flatpak #16868

davidhedlund opened this issue Aug 11, 2024 · 9 comments

Comments

@davidhedlund
Copy link
Contributor

davidhedlund commented Aug 11, 2024

Description

In the Flatpak version of RetroArch, Sony PlayStation controllers are incorrectly labeled as "PS[X] Controller" ("Save Controller Profile" generates [controller name].cfg with content input_device = [controller name]) regardless of the Linux kernel version. This issue does not occur with the Appimage version.

For comparison, other controllers such as the Nintendo Switch Pro Controller are correctly identified and saved as "Nintendo Switch Pro Controller.cfg" across sdl2, udev, and linuxraw drivers.

Expected Behavior

Ubuntu MATE 23.04

On Ubuntu MATE 23.04 with Linux kernel 6.2.0, udev, and linuxraw correctly identifies the DualSense and DualShock 4 v2 controllers as "DualSense Wireless Controller" and "Wireless Controller" respectively.

So with sdl2:

  • When a DualSense controller is connected and "Save Controller Profile" is clicked, it should save as "DualSense Wireless Controller.cfg".
  • When a DualShock 4 v2 controller is connected and "Save Controller Profile" is clicked, it should save as "Wireless Controller.cfg".

Ubuntu MATE 22.04 and Ubuntu MATE 24.04

On Ubuntu MATE 22.04 with Linux kernel 5.19.0 and Ubuntu MATE 24.04 with Linux kernel 6.8.0, udev, and linuxraw correctly identifies the DualSense and DualShock 4 v2 controllers as "Sony Interactive Entertainment DualSense Wireless Controller" and "Sony Interactive Entertainment Wireless Controller" respectively.

So with sdl2:

  • When a DualSense controller is connected and "Save Controller Profile" is clicked, it should save as "Sony Interactive Entertainment DualSense Wireless Controller.cfg".
  • When a DualShock 4 v2 controller is connected and "Save Controller Profile" is clicked, it should save as "Sony Interactive Entertainment Wireless Controller.cfg".

Steps to Reproduce the Bug

  1. Follow the controller guide to change the Controller Profiles directory.
  2. Go to Settings -> Drivers -> Controller and set it to "sdl2".
  3. Connect a PlayStation 4 or PlayStation 5 controller.
  4. Navigate to Settings -> Input -> RetroPad Binds -> Port 1 Controls.
  5. Connect a DualSense controller and click "Save Controller Profile". It will save as "PS5 Controller.cfg".
  6. Disconnect the DualSense controller.
  7. Connect a DualShock 4 v2 controller and click "Save Controller Profile". It will save as "PS4 Controller.cfg".

Version/Commit

  • RetroArch: 1.19.1 Flatpak

Environment Information

  • OS: Ubuntu MATE 22.04, 23.04 (likely not OS-specific)
davidhedlund added a commit to davidhedlund/retroarch-joypad-autoconfig that referenced this issue Aug 11, 2024
…inment Wireless Controller.cfg

# Manually renamed from "PS4 Controller.cfg", see libretro/RetroArch#16868
davidhedlund added a commit to davidhedlund/retroarch-joypad-autoconfig that referenced this issue Aug 11, 2024
davidhedlund added a commit to davidhedlund/retroarch-joypad-autoconfig that referenced this issue Aug 11, 2024
@gouchi
Copy link
Member

gouchi commented Aug 13, 2024

There is an issue with udev on Flatpak so they switch to SDL2.

It seems it is the name given by the SDL2 Game controller community database. You can check it using SDL2 Gamepad Mapper.

So I am not sure we can change it.

@RobLoach
Copy link
Member

What gouchi said. The filename that is saved is determined by the input driver, and not a symptom of RetroArch itself. Feel free to rename the file to what you want it to be and send it in a PR to https://github.com/libretro/retroarch-joypad-autoconfig/

@davidhedlund
Copy link
Contributor Author

What gouchi said. The filename that is saved is determined by the input driver, and not a symptom of RetroArch itself. Feel free to rename the file to what you want it to be and send it in a PR to https://github.com/libretro/retroarch-joypad-autoconfig/

As I said in the top post:

This issue does not occur with the Appimage version.

Should I file a bug report to the Appimage repo?

@gouchi
Copy link
Member

gouchi commented Aug 14, 2024

This issue does not occur with the Appimage version.

Should I file a bug report to the Appimage repo?

It should give the same result using SDL2 driver for the Flatpak and AppImage.

So you might open an issue but we don't have AppImage repo just Flatpak and snap.

Thank you.

@davidhedlund
Copy link
Contributor Author

There is an issue with udev on Flatpak so they switch to SDL2.

It seems it is the name given by the SDL2 Game controller community database. You can check it using SDL2 Gamepad Mapper.

So I am not sure we can change it.

Thank you very much for the database reference.

@davidhedlund
Copy link
Contributor Author

So you might open an issue but we don't have AppImage repo just Flatpak and snap.

Are you aware of this?:

@davidhedlund
Copy link
Contributor Author

@gouchi
Copy link
Member

gouchi commented Aug 18, 2024

Are you aware of this?:
https://github.com/hizzlekizzle/RetroArch-AppImage/issues

Yes I know it. But we are using Gitlab CI/CD to build the AppImage package.

I meant we don't have dedicated repo for the AppImage package so you might open an issue in this repo.

Thank you.

@davidhedlund
Copy link
Contributor Author

Are you aware of this?:
https://github.com/hizzlekizzle/RetroArch-AppImage/issues

Yes I know it. But we are using Gitlab CI/CD to build the AppImage package.

I meant we don't have dedicated repo for the AppImage package so you might open an issue in this repo.

Thank you.

Thanks back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants