SDL_image cmake doesn't use includes from SDL3_DIR

[maia-s]

I'm on macos and have SDL3 version 3.2.4 installed via brew. SDL_image 3.2.2 requires SDL 3.2.6, so configuring SDL_image without setting anything else fails at cmake configuration time, as expected.

If I build and do a temporary local install of SDL 3.2.6 and pass its cmake configuration dir to SDL_image via the SDL3_DIR cmake variable, cmake configuration succeeds, but then compilation fails later on:

make: warning: jobserver unavailable: using -j1.  Add `+' to parent make rule.
  /Users/maia/Dev/sdl3-sys/sdl3-image-src/SDL_image/src/IMG_bmp.c:429:38: error: use of undeclared identifier 'SDL_PROP_SURFACE_HOTSPOT_X_NUMBER'
    429 |         SDL_SetNumberProperty(props, SDL_PROP_SURFACE_HOTSPOT_X_NUMBER, nHotX);
        |                                      ^
  /Users/maia/Dev/sdl3-sys/sdl3-image-src/SDL_image/src/IMG_bmp.c:430:38: error: use of undeclared identifier 'SDL_PROP_SURFACE_HOTSPOT_Y_NUMBER'
    430 |         SDL_SetNumberProperty(props, SDL_PROP_SURFACE_HOTSPOT_Y_NUMBER, nHotY);
        |                                      ^
  2 errors generated.
  make[2]: *** [CMakeFiles/SDL3_image-shared.dir/src/IMG_bmp.c.o] Error 1
  make[1]: *** [CMakeFiles/SDL3_image-shared.dir/all] Error 2
  make: *** [all] Error 2

It appears SDL_image is using the headers from the brew install instead of the headers set via SDL3_DIR.

[madebr]

Does this error also happen if you build SDL3_image with vendored dependencies?
This tests a hypothesis that the include directories of the file format libraries pull in the wrong SDL3 headers.

[maia-s]

It still happens if I only enable SDLIMAGE_VENDORED, but if I set SDLIMAGE_VENDORED to ON and also set SDLIMAGE_WEBP to OFF, it builds. This is really weird. It still fails if I only disable webp and don't enable vendored.

[rdrsss]

+1, Also experiencing this when adding to my project.

[madebr]

SDL_image/CMakeLists.txt

Lines 990 to 997 in 4fc7410

	target_include_directories(${sdl3_image_target_name} PRIVATE
	$<TARGET_PROPERTY:WebP::webp,INCLUDE_DIRECTORIES>
	$<TARGET_PROPERTY:WebP::webp,INTERFACE_INCLUDE_DIRECTORIES>
	$<TARGET_PROPERTY:WebP::webp,INTERFACE_SYSTEM_INCLUDE_DIRECTORIES>
	$<TARGET_PROPERTY:WebP::webpdemux,INCLUDE_DIRECTORIES>
	$<TARGET_PROPERTY:WebP::webpdemux,INTERFACE_INCLUDE_DIRECTORIES>
	$<TARGET_PROPERTY:WebP::webpdemux,INTERFACE_SYSTEM_INCLUDE_DIRECTORIES>
	)

Does removing line 991 and 994 change the behavior?

[rdrsss]

@madebr for me no, the error remains.

[rdrsss]

@madebr I was able to fix this for myself. I realized i was on SDL 3.2.4 not 3.2.8. In the prior version SDL_PROP_SURFACE_HOTSPOT_X_NUMBER was not included as part of SDL_surface.h in the regular path but only in the macos framework path, so it wasn't resolving to the right header. Updating this has since fixed the issue. Thank you for your help.

[maia-s]

This isn't fixed. My issue isn't related to the framework. I did have an old SDL3 framework installed too, but that wasn't the issue.

Homebrew has since updated sdl3 to 3.2.8, but if I replace the headers in the brew install with 3.2.4 headers this still fails in the same way even though I pass an SDL3 3.2.8 install with 3.2.8 headers via SDL3_DIR to SDL_Image's cmake. Ie it picks up brew's headers in favor of the ones explicitly passed via SDL3_DIR.