Skip to content

Commit e59b65e

Browse files
committed
feat(compas-convert): use @lightbase/utils, bump some dependencies
Signed-off-by: Dirk de Visser <[email protected]>
1 parent dc814eb commit e59b65e

File tree

4 files changed

+11
-22
lines changed

4 files changed

+11
-22
lines changed

packages/compas-convert/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ rm -rf ../compas-convert-test && npx compas-convert ../some-local-test-project .
6363

6464
Checklist:
6565

66-
- [ ] Any TS errors we need to fix still?
66+
- [x] Any TS errors we need to fix still?
6767
- Start documenting common errors and their fixes below
6868
- [x] CRUD file errors add `@ts-nocheck` or comparable.
6969
- [x] Check on generated input/output types for things like `ctx.body`
70-
- [ ] Add `@lightbase/utils` package, and use that for `assertNotNil`.
70+
- [x] Add `@lightbase/utils` package, and use that for `assertNotNil`.
7171
- [x] Verify that all maintained projects at least convert.
7272
- [x] Any ESLint rules we can fix?
7373
- Start documenting common errors and their fixes below

packages/compas-convert/src/passes/add-common-imports.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function addCommonImports(context: Context, sourceFile: SourceFile) {
2525
addPendingImport(
2626
context,
2727
sourceFile,
28-
resolveRelativeImport(context, sourceFile, CONVERT_UTIL_PATH),
28+
"@lightbase/utils",
2929
CONVERT_UTIL.assertNotNil,
3030
false,
3131
);

packages/compas-convert/src/passes/init-ts-morph.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,6 @@ import { AppError } from "@compas/stdlib";
4949
// eslint-disable-next-line @typescript-eslint/no-explicit-any
5050
export type $ConvertAny = any;
5151
52-
/**
53-
* Asserts that the provided value is not null or undefined.
54-
*/
55-
export function assertNotNil<T>(
56-
value: T,
57-
message?: string,
58-
): asserts value is NonNullable<T> {
59-
if (value === null || value === undefined) {
60-
throw new Error(\`Invariant failed: $\{ message }\`);
61-
}
62-
}
63-
6452
/**
6553
* Asserts that the provided value is of type AppError
6654
*

packages/compas-convert/src/passes/init-typescript-in-project.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,18 @@ export async function initTypescriptInProject(context: Context) {
1111

1212
packageJson.devDependencies ??= {};
1313
packageJson.devDependencies["tsx"] = "4.19.2";
14-
packageJson.devDependencies["typescript"] = "5.6.3";
15-
packageJson.devDependencies["vitest"] = "2.0.5";
14+
packageJson.devDependencies["typescript"] = "5.7.3";
15+
packageJson.devDependencies["vitest"] = "3.0.4";
1616
packageJson.devDependencies["@total-typescript/tsconfig"] = "1.0.4";
1717
packageJson.devDependencies["@types/node"] = "latest";
18-
packageJson.devDependencies["@compas/code-gen"] = "0.15.6";
18+
packageJson.devDependencies["@compas/code-gen"] = "0.15.8";
1919

2020
packageJson.dependencies ??= {};
21-
packageJson.dependencies["@compas/cli"] = "0.15.6";
22-
packageJson.dependencies["@compas/server"] = "0.15.6";
23-
packageJson.dependencies["@compas/stdlib"] = "0.15.6";
24-
packageJson.dependencies["@compas/store"] = "0.15.6";
21+
packageJson.dependencies["@lightbase/utils"] = "1.0.3";
22+
packageJson.dependencies["@compas/cli"] = "0.15.8";
23+
packageJson.dependencies["@compas/server"] = "0.15.8";
24+
packageJson.dependencies["@compas/stdlib"] = "0.15.8";
25+
packageJson.dependencies["@compas/store"] = "0.15.8";
2526

2627
packageJson.scripts ??= {};
2728
packageJson.scripts["build"] = `tsc -p ./tsconfig.json`;

0 commit comments

Comments
 (0)