[test-flake]: flake in itest custom_channels_liquidity #1171
Description
itest flake noticed in Taproot Assets repo CI run: https://github.com/lightninglabs/taproot-assets/actions/runs/19245969484/job/55067805197?pr=1832
Relevant logs from CI run:
litd_custom_channels_test.go:3238:
Error Trace: /home/runner/work/taproot-assets/taproot-assets/lightning-terminal/itest/assets_test.go:3004
/home/runner/work/taproot-assets/taproot-assets/lightning-terminal/itest/litd_custom_channels_test.go:3238
/home/runner/work/taproot-assets/taproot-assets/lightning-terminal/itest/litd_custom_channels_test.go:3347
/home/runner/work/taproot-assets/taproot-assets/lightning-terminal/itest/test_harness.go:103
/home/runner/work/taproot-assets/taproot-assets/lightning-terminal/itest/litd_test.go:88
Error: Received unexpected error:
expected 0 HTLCs, got 4, (string) (len=8332) "{\n \"channels\": [\n {\n \"active\": true,\n \"remote_pubkey\": \"02e23b6579d58464f963f3da886b4228f17ab3a25285d046f3e4f3b30180adfd57\",\n \"channel_point\": \"8320c1723f16a014ff0b8881293c43f75b40de69753be2bdf40b5b84740fab56:0\",\n \"chan_id\": \"515670953492480\",\n \"capacity\": \"10000000\",\n \"local_balance\": \"1190023\",\n \"remote_balance\": \"7463427\",\n \"commit_fee\": \"3672\",\n \"commit_weight\": \"1460\",\n \"fee_per_kw\": \"2500\",\n \"unsettled_balance\": \"1342218\",\n \"total_satoshis_sent\": \"0\",\n \"total_satoshis_received\": \"1190023\",\n \"num_updates\": \"46\",\n \"pending_htlcs\": [\n {\n \"incoming\": true,\n \"amount\": \"1073774\",\n \"hash_lock\": \"ac6fae17e7a3bd66a23c50fc3013bfa214508d13ff32ba337921f85c87ed087f\",\n \"expiration_height\": 646,\n \"htlc_index\": \"23\",\n \"forwarding_channel\": \"525566558142464\",\n \"forwarding_htlc_index\": \"8\",\n \"locked_in\": true\n },\n {\n \"incoming\": true,\n \"amount\": \"268444\",\n \"hash_lock\": \"ac6fae17e7a3bd66a23c50fc3013bfa214508d13ff32ba337921f85c87ed087f\",\n \"expiration_height\": 646,\n \"htlc_index\": \"27\",\n \"forwarding_channel\": \"525566558142464\",\n \"forwarding_htlc_index\": \"9\",\n \"locked_in\": true\n }\n ],\n \"csv_delay\": 4,\n \"private\": false,\n \"initiator\": false,\n \"chan_status_flags\": \"ChanStatusDefault\",\n \"local_chan_reserve_sat\": \"100000\",\n \"remote_chan_reserve_sat\": \"100000\",\n \"static_remote_key\": false,\n \"commitment_type\": \"ANCHORS\",\n \"lifetime\": \"130\",\n \"uptime\": \"130\",\n \"close_address\": \"\",\n \"push_amount_sat\": \"0\",\n \"thaw_height\": 0,\n \"local_constraints\": {\n \"csv_delay\": 4,\n \"chan_reserve_sat\": \"100000\",\n \"dust_limit_sat\": \"354\",\n \"max_pending_amt_msat\": \"9900000000\",\n \"min_htlc_msat\": \"1\",\n \"max_accepted_htlcs\": 483\n },\n \"remote_constraints\": {\n \"csv_delay\": 4,\n \"chan_reserve_sat\": \"100000\",\n \"dust_limit_sat\": \"354\",\n \"max_pending_amt_msat\": \"9900000000\",\n \"min_htlc_msat\": \"1\",\n \"max_accepted_htlcs\": 483\n },\n \"alias_scids\": [\n \"17592186044416000000\"\n ],\n \"zero_conf\": false,\n \"zero_conf_confirmed_scid\": \"0\",\n \"peer_alias\": \"\",\n \"peer_scid_alias\": \"17592186044416000000\",\n \"memo\": \"\",\n \"custom_channel_data\": \"\"\n },\n {\n \"active\": false,\n \"remote_pubkey\": \"0304ce7297a9ca6bacbe9520b5bb92f93c79d6217f3572ccbe00fe5d4d7116ae36\",\n \"channel_point\": \"9c33044324bbc4ed927afacbe9fd7e828d9d4bf1d8ecbfbb3bf50aa78add7402:0\",\n \"chan_id\": \"525566558142464\",\n \"capacity\": \"100000\",\n \"local_balance\": \"75351\",\n \"remote_balance\": \"20001\",\n \"commit_fee\": \"3280\",\n \"commit_weight\": \"1302\",\n \"fee_per_kw\": \"2500\",\n \"unsettled_balance\": \"708\",\n \"total_satoshis_sent\": \"20001\",\n \"total_satoshis_received\": \"0\",\n \"num_updates\": \"11\",\n \"pending_htlcs\": [\n {\n \"incoming\": false,\n \"amount\": \"354\",\n \"hash_lock\": \"ac6fae17e7a3bd66a23c50fc3013bfa214508d13ff32ba337921f85c87ed087f\",\n \"expiration_height\": 566,\n \"htlc_index\": \"8\",\n \"forwarding_channel\": \"515670953492480\",\n \"forwarding_htlc_index\": \"23\",\n \"locked_in\": true\n },\n {\n \"incoming\": false,\n \"amount\": \"354\",\n \"hash_lock\": \"ac6fae17e7a3bd66a23c50fc3013bfa214508d13ff32ba337921f85c87ed087f\",\n \"expiration_height\": 566,\n \"htlc_index\": \"9\",\n \"forwarding_channel\": \"515670953492480\",\n \"forwarding_htlc_index\": \"27\",\n \"locked_in\": true\n }\n ],\n \"csv_delay\": 4,\n \"private\": true,\n \"initiator\": true,\n \"chan_status_flags\": \"ChanStatusDefault\",\n \"local_chan_reserve_sat\": \"1000\",\n \"remote_chan_reserve_sat\": \"1062\",\n \"static_remote_key\": false,\n \"commitment_type\": \"SIMPLE_TAPROOT_OVERLAY\",\n \"lifetime\": \"122\",\n \"uptime\": \"122\",\n \"close_address\": \"\",\n \"push_amount_sat\": \"0\",\n \"thaw_height\": 0,\n \"local_constraints\": {\n \"csv_delay\": 4,\n \"chan_reserve_sat\": \"1000\",\n \"dust_limit_sat\": \"354\",\n \"max_pending_amt_msat\": \"99000000\",\n \"min_htlc_msat\": \"1\",\n \"max_accepted_htlcs\": 83\n },\n \"remote_constraints\": {\n \"csv_delay\": 4,\n \"chan_reserve_sat\": \"1062\",\n \"dust_limit_sat\": \"354\",\n \"max_pending_amt_msat\": \"99000000\",\n \"min_htlc_msat\": \"1\",\n \"max_accepted_htlcs\": 83\n },\n \"alias_scids\": [\n \"17592186044416000001\",\n \"17735480042115657037\",\n \"17653732518154453703\",\n \"17757763854809208194\"\n ],\n \"zero_conf\": false,\n \"zero_conf_confirmed_scid\": \"0\",\n \"peer_alias\": \"\",\n \"peer_scid_alias\": \"17592186044416000000\",\n \"memo\": \"\",\n \"custom_channel_data\": \"7b2266756e64696e675f617373657473223a5b7b2276657273696f6e223a312c2261737365745f67656e65736973223a7b2267656e657369735f706f696e74223a22383666303837653962303131366363393938336366383935353865623731346439616438353963626163666437363165653035386430663163313230383632383a30222c226e616d65223a2269746573742d61737365742d63656e7473222c226d6574615f68617368223a2238313161643363343266333535633931356431666334626134656437313333373039323139313433313330386639373564376163626338386130396162393831222c2261737365745f6964223a2263323336386239343033343531613163643663653661353766663862346339633534633234363261343264316264646430643365623064356337363436666461227d2c22616d6f756e74223a3230303030302c227363726970745f6b6579223a22303235306161656231363666343233343635306438346132643861313330393837616561663639353032303665303930353430316565373466663366386431386536222c22646563696d616c5f646973706c6179223a307d5d2c226c6f63616c5f617373657473223a5b7b2261737365745f6964223a2263323336386239343033343531613163643663653661353766663862346339633534633234363261343264316264646430643365623064356337363436666461222c22616d6f756e74223a31313938327d5d2c2272656d6f74655f617373657473223a5b7b2261737365745f6964223a2263323336386239343033343531613163643663653661353766663862346339633534633234363261343264316264646430643365623064356337363436666461222c22616d6f756e74223a3130393839347d5d2c226f7574676f696e675f68746c6373223a5b7b2261737365745f6964223a2263323336386239343033343531613163643663653661353766663862346339633534633234363261343264316264646430643365623064356337363436666461222c22616d6f756e74223a36323439397d2c7b2261737365745f6964223a2263323336386239343033343531613163643663653661353766663862346339633534633234363261343264316264646430643365623064356337363436666461222c22616d6f756e74223a31353632357d5d2c22696e636f6d696e675f68746c6373223a5b5d2c226361706163697479223a3230303030302c226c6f63616c5f62616c616e6365223a31313938322c2272656d6f74655f62616c616e6365223a3130393839342c226f7574676f696e675f68746c635f62616c616e6365223a37383132342c22696e636f6d696e675f68746c635f62616c616e6365223a307d\"\n }\n ]\n}"
Test: TestLightningTerminal/custom_channels_liquidity
harness.go:393: finished test: , start height=438, end height=483, mined blocks=45
harness.go:415: !============================================!
Too many blocks (45) mined in one test! Tips:
1. break test into smaller individual tests, especially if this is a table-drive test.
2. use smaller CSV via `--bitcoin.defaultremotedelay=1.`
3. use smaller CLTV via `--bitcoin.timelockdelta=18.`
4. remove unnecessary CloseChannel when test ends.
5. use `CreateSimpleNetwork` for efficient channel creation.
harness.go:352: test failed, skipped cleanup
=== NAME TestLightningTerminal
litd_test.go:102: Failure time: 2025-11-11 10:13:25.500
--- FAIL: TestLightningTerminal (528.68s)
--- PASS: TestLightningTerminal/custom_channels (66.40s)
--- PASS: TestLightningTerminal/custom_channels_backward_compatibility (61.07s)
--- PASS: TestLightningTerminal/custom_channels_large (40.06s)
--- PASS: TestLightningTerminal/custom_channels_grouped_asset (62.23s)
--- PASS: TestLightningTerminal/custom_channels_group_tranches_force_close (48.37s)
--- PASS: TestLightningTerminal/custom_channels_group_tranches_htlc_force_close (55.82s)
--- PASS: TestLightningTerminal/custom_channels_force_close (23.86s)
--- PASS: TestLightningTerminal/custom_channels_breach (23.12s)
--- FAIL: TestLightningTerminal/custom_channels_liquidity (147.75s)
FAIL