Merge pull request #504 from sputn1ck/fix_suggest_swaps_rpc

sputn1ck · web-flow · commit 3931c2704360 · 2022-06-08T15:38:00.000+02:00
looprpc: fix suggestswaps response
diff --git a/loopd/swapclient_server.go b/loopd/swapclient_server.go
@@ -885,9 +885,12 @@ func (s *swapClientServer) SuggestSwaps(ctx context.Context,
 			return nil, err
 		}
 
+		clonedPubkey := route.Vertex{}
+		copy(clonedPubkey[:], pubkey[:])
+
 		exclChan := &clientrpc.Disqualified{
 			Reason: autoloopReason,
-			Pubkey: pubkey[:],
+			Pubkey: clonedPubkey[:],
 		}
 
 		resp.Disqualified = append(resp.Disqualified, exclChan)
diff --git a/release_notes.md b/release_notes.md
@@ -22,5 +22,5 @@ This file tracks release notes for the loop client.
 #### Breaking Changes
 
 #### Bug Fixes
-
+* The `SuggestSwaps` rpc now returns the correct peer pubkeys in the disqualified  list.
 #### Maintenance
diff --git a/version.go b/version.go
@@ -27,7 +27,7 @@ const (
 	// Note: please update release_notes.md when you change these values.
 	appMajor uint = 0
 	appMinor uint = 19
-	appPatch uint = 0
+	appPatch uint = 1
 
 	// appPreRelease MUST only contain characters from semanticAlphabet per
 	// the semantic versioning spec.

Original file line number	Diff line number	Diff line change
`@@ -885,9 +885,12 @@ func (s *swapClientServer) SuggestSwaps(ctx context.Context,`
`885`	`885`	`return nil, err`
`886`	`886`	`}`
`887`	`887`
	`888`	`+ clonedPubkey := route.Vertex{}`
	`889`	`+ copy(clonedPubkey[:], pubkey[:])`
	`890`	`+`
`888`	`891`	`exclChan := &clientrpc.Disqualified{`
`889`	`892`	`Reason: autoloopReason,`
`890`		`- Pubkey: pubkey[:],`
	`893`	`+ Pubkey: clonedPubkey[:],`
`891`	`894`	`}`
`892`	`895`
`893`	`896`	`resp.Disqualified = append(resp.Disqualified, exclChan)`