Skip to content

[bug]: AddInvoiceResponse only returns a single accepted_buy_quote #1565

Open
@ZZiigguurraatt

Description

@ZZiigguurraatt

AddInvoiceResponse only returns a single accepted_buy_quote. Now that we have #1457 , this does not make sense. I'm not sure if this is the worst accepted_buy_quote, the best, or the first one. We should have all accepted_buy_quote returned, and there should be an indication which one is used to set the sats amount in the invoice that is generated.

message AddInvoiceResponse {
// The quote for the purchase of assets that was accepted by the peer.
rfqrpc.PeerAcceptedBuyQuote accepted_buy_quote = 1;

I can decode the returned invoice to get a list of SCID and peer pubkeys used for each quote, but that does not tell me the quote amount, only which peers I also got quotes with. Also, I don't think a user should need to decode the returned invoice just to get the SCID and peer pubkeys.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions