graphdb: invalidate node cache

In this commit, we remove nodes from the node cache in various db
method call site which execution could affect the public status of
the nodes.

Author: Abdulkbk

graph/db/sql_store.go

@@ -435,6 +435,10 @@ func (s *SQLStore) DeleteNode(ctx context.Context,
 		return fmt.Errorf("unable to delete node: %w", err)
 	}
 
+	s.cacheMu.Lock()
+	s.removePublicNodeCache(pubKey)
+	s.cacheMu.Unlock()
+
 	return nil
 }
 
@@ -734,6 +738,10 @@ func (s *SQLStore) AddChannelEdge(ctx context.Context,
 			default:
 				s.rejectCache.remove(edge.ChannelID)
 				s.chanCache.remove(edge.ChannelID)
+				s.removePublicNodeCache(
+					edge.NodeKey1Bytes, edge.NodeKey2Bytes,
+				)
+
 				return nil
 			}
 		},
@@ -1740,6 +1748,7 @@ func (s *SQLStore) MarkEdgeZombie(chanID uint64,
 
 	s.rejectCache.remove(chanID)
 	s.chanCache.remove(chanID)
+	s.removePublicNodeCache(pubKey1, pubKey2)
 
 	return nil
 }
@@ -1965,6 +1974,14 @@ func (s *SQLStore) DeleteChannelEdges(strictZombiePruning, markZombie bool,
 		s.chanCache.remove(chanID)
 	}
 
+	var pubkeys [][33]byte
+	for _, edge := range edges {
+		pubkeys = append(
+			pubkeys, edge.NodeKey1Bytes, edge.NodeKey2Bytes,
+		)
+	}
+	s.removePublicNodeCache(pubkeys...)
+
 	return edges, nil
 }
 
@@ -2694,6 +2711,9 @@ func (s *SQLStore) PruneGraph(spentOutputs []*wire.OutPoint,
 	for _, channel := range closedChans {
 		s.rejectCache.remove(channel.ChannelID)
 		s.chanCache.remove(channel.ChannelID)
+		s.removePublicNodeCache(
+			channel.NodeKey1Bytes, channel.NodeKey2Bytes,
+		)
 	}
 
 	return closedChans, prunedNodes, nil
@@ -2958,9 +2978,15 @@ func (s *SQLStore) DisconnectBlockAtHeight(height uint32) (
 			"height: %w", err)
 	}
 
+	s.cacheMu.Lock()
+	defer s.cacheMu.Unlock()
+
 	for _, channel := range removedChans {
 		s.rejectCache.remove(channel.ChannelID)
 		s.chanCache.remove(channel.ChannelID)
+		s.removePublicNodeCache(
+			channel.NodeKey1Bytes, channel.NodeKey2Bytes,
+		)
 	}
 
 	return removedChans, nil
@@ -5783,3 +5809,13 @@ func handleZombieMarking(ctx context.Context, db SQLQueries,
 		},
 	)
 }
+
+// removePublicNodeCache takes in a list of public keys and removes the
+// corresponding nodes info from the cache if it exists.
+//
+// NOTE: This method must be called with cacheMu held.
+func (s *SQLStore) removePublicNodeCache(pubkeys ...[33]byte) {
+	for _, pubkey := range pubkeys {
+		s.publicNodeCache.Delete(pubkey)
+	}
+}