Skip to content

Commit ade4917

Browse files
committed
server: remove accountability signal experiment period
In the previous iteration with endorsement signaling, the recommendation was for the sender to set it to 1 and that could have had privacy concerns when first deploying given that the default was to downgrade the signal to 0. In the latest proposal the recommended default for both sending and forwarding nodes is to set `accountable` to 0. As a result, the dates have been removed given that there are no privacy risks associated with relaying the signal with zero values.
1 parent 82a27b4 commit ade4917

File tree

3 files changed

+2
-22
lines changed

3 files changed

+2
-22
lines changed

htlcswitch/link.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3346,8 +3346,6 @@ func (l *channelLink) processRemoteAdds(fwdPkg *channeldb.FwdPkg) {
33463346
func (l *channelLink) experimentalAccountability(
33473347
customUpdateAdd record.CustomSet) fn.Option[byte] {
33483348

3349-
// Only relay experimental signal if we are within the experiment
3350-
// period.
33513349
if !l.cfg.ShouldFwdExpAccountability() {
33523350
return fn.None[byte]()
33533351
}

rpcserver.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -775,13 +775,7 @@ func (r *rpcServer) addDeps(ctx context.Context, s *server,
775775
return nil
776776
},
777777
ShouldSetExpAccountability: func() bool {
778-
if s.cfg.ProtocolOptions.NoExperimentalAccountability() {
779-
return false
780-
}
781-
782-
return clock.NewDefaultClock().Now().Before(
783-
AccountabilityExperimentEnd,
784-
)
778+
return !s.cfg.ProtocolOptions.NoExperimentalAccountability()
785779
},
786780
}
787781

server.go

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,6 @@ var (
138138
// TODO(roasbeef): add command line param to modify.
139139
MaxFundingAmount = funding.MaxBtcFundingAmount
140140

141-
// AccountabilityExperimentEnd is the time after which nodes should stop
142-
// propagating experimental accountable signals.
143-
//
144-
// Per blip04: January 1, 2026 12:00:00 AM UTC in unix seconds.
145-
AccountabilityExperimentEnd = time.Unix(1767225600, 0)
146-
147141
// ErrGossiperBan is one of the errors that can be returned when we
148142
// attempt to finalize a connection to a remote peer.
149143
ErrGossiperBan = errors.New("gossiper has banned remote's key")
@@ -4421,13 +4415,7 @@ func (s *server) peerConnected(conn net.Conn, connReq *connmgr.ConnReq,
44214415
AuxTrafficShaper: s.implCfg.TrafficShaper,
44224416
AuxChannelNegotiator: s.implCfg.AuxChannelNegotiator,
44234417
ShouldFwdExpAccountability: func() bool {
4424-
if s.cfg.ProtocolOptions.NoExperimentalAccountability() {
4425-
return false
4426-
}
4427-
4428-
return clock.NewDefaultClock().Now().Before(
4429-
AccountabilityExperimentEnd,
4430-
)
4418+
return !s.cfg.ProtocolOptions.NoExperimentalAccountability()
44314419
},
44324420
NoDisconnectOnPongFailure: s.cfg.NoDisconnectOnPongFailure,
44334421
}

0 commit comments

Comments
 (0)