Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chanbackup/[feature]: add archive mode for channel back ups #8906

Open
Roasbeef opened this issue Jul 10, 2024 · 2 comments · May be fixed by #9232
Open

chanbackup/[feature]: add archive mode for channel back ups #8906

Roasbeef opened this issue Jul 10, 2024 · 2 comments · May be fixed by #9232
Assignees
@Abdulkbk
Labels
beginner Issues suitable for new developers enhancement Improvements to existing features / behaviour safety General label for issues/PRs related to the safety of using the software SCB Related to static channel backup

Comments

@Roasbeef
Copy link
Member

Is your feature request related to a problem? Please describe.

To ensure that certain classes of recovery are always possible, we should considering adding a mode to never delete channel backups, and only rename or move them to a special folder that stores archived chanenls. They're relatively small (~300 bytes or so), so it shouldn't take up a significant amount of disk space.

Describe the solution you'd like

Implement the above behavior by default, adding a flag to optionally disable it.

Describe alternatives you've considered

Users can also use the various notify scripts to always grab and archive the backups themselves. This requires extra software.
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour beginner Issues suitable for new developers safety General label for issues/PRs related to the safety of using the software SCB Related to static channel backup labels Jul 10, 2024
@Abdulkbk
Copy link
Contributor

Hi @Roasbeef I'm picking this up

@Abdulkbk Abdulkbk linked a pull request Oct 29, 2024 that will close this issue
Open
8 tasks
@Abdulkbk
Copy link
Contributor

Abdulkbk commented Nov 1, 2024

Hi @Roasbeef, I opened a PR here to fix this. Please take a look and provide feedback. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abdulkbk Abdulkbk

Labels
beginner Issues suitable for new developers enhancement Improvements to existing features / behaviour safety General label for issues/PRs related to the safety of using the software SCB Related to static channel backup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chanbackup: archive old channel backups Abdulkbk/lnd
2 participants
@Roasbeef @Abdulkbk