You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry - normally I'd submit a pull request for this kind of thing but unfortunately I don't have time.
Many people new to the project will start by working through the examples in the README so it's relatively important that it be mistake free. Here are some issues I found:
intercept[ArithmeticException]{
b.now // Otherwise it complains "No implicit Ctx.Data is available here!"
}
assert(b.toTry.isInstanceOf[Failure[_]]) // Otherwise it complains "class Failure takes type parameters "assert(b.toTry.isInstanceOf[Failure])
2. An unknown function inside is referenced a number of times, e.g. like so:
inside(c.toTry){caseSuccess(0) => () }
I think occurances of inside should be replaced with assertMatch
assertMatch(c.toTry){caseSuccess(0) => ()}
But then it's probably necessary to go on and explain that to use assertMatch you have to extend TestSuite from https://github.com/lihaoyi/utest
Sorry - normally I'd submit a pull request for this kind of thing but unfortunately I don't have time.
Many people new to the project will start by working through the examples in the
README
so it's relatively important that it be mistake free. Here are some issues I found:1. I had to change the following code:
To this:
2. An unknown function
inside
is referenced a number of times, e.g. like so:I think occurances of
inside
should be replaced withassertMatch
But then it's probably necessary to go on and explain that to use
assertMatch
you have to extendTestSuite
from https://github.com/lihaoyi/utest3. In the following code why is
a
wrapped in anotherRx
when creatingb
- isn'ta
already a perfectly acceptableRx
?The text was updated successfully, but these errors were encountered: