Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation message from Imagine lib #1618

Open
sdespont opened this issue Jan 7, 2025 · 1 comment
Open

Deprecation message from Imagine lib #1618

sdespont opened this issue Jan 7, 2025 · 1 comment
Milestone

Comments

@sdespont
Copy link

sdespont commented Jan 7, 2025

The library 2.13.3 has a deprecation message from Imagine when the filter is applied :

deprecation.INFO: User Deprecated: Method "Imagine\Filter\FilterInterface::apply()" might add "\Imagine\Image\ImageInterface" as a native return type declaration in the future. Do the same in implementation "Liip\ImagineBundle\Imagine\Filter\RelativeResize" now to avoid errors or add an explicit @return annotation to suppress this message.

@dbu dbu added this to the 3.0.0 milestone Jan 13, 2025
@dbu
Copy link
Member

dbu commented Jan 13, 2025

we still support legacy PHP versions and therefor can't declare the return type on our implementations. i tagged this issue with the 3.0.0 milestone so we don't forget to clean this up when we create a new major version.

if the deprecation warnings annoy you, please do a pull request against the 2.x branch that adds the @return annotations to all filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants