Remove annotation support

[Spea]

Drops support for serializer annotations. Type annotations still have to be parsed in order to properly set the types in the metadata.

[dbu]

thanks for this cleanup!

i see one problem with this: jms serializer still supports annotations. it might confuse people massively when suddenly their annotations are ignored. i wonder if we need to keep reading the jms annotations if present, and only drop our own annotations support (which should error with properly configured php, when trying to use a no longer existing annotation)

[Spea]

thanks for this cleanup!

i see one problem with this: jms serializer still supports annotations. it might confuse people massively when suddenly their annotations are ignored. i wonder if we need to keep reading the jms annotations if present, and only drop our own annotations support (which should error with properly configured php, when trying to use a no longer existing annotation)

I was already hesitant in removing annotation support for JMS anyway, so I agree that we should keep it (for now) and only remove it if JMS itself decides to remove it as well. I reverted the changes that removed the annotation support, but I still went with renaming annotation(s) to attribute(s).

[dbu]

thanks a lot. yes i agree with the renaming, that is a potential BC break so we need to do this now.
when jms ditches annotations, we can do another major version.

in #48 , we had the idea to make attributes optional and not require the library anymore. then we would have to change the attribute parser to not attempt to read annotations if the library is not available. if you are up for that, would be cool to change it. but i am fine keeping it if you don't have the time to invest into it.

[dbu]

we should merge this with the above line:

* Replaced `@Preferred` annotation with the `#Preferred` attribute

[Spea]

Yeah makes sense to not have two entries for the same change. I fixed this and amended to the original commit.

[Spea]

in #48 , we had the idea to make attributes optional and not require the library anymore. then we would have to change the attribute parser to not attempt to read annotations if the library is not available. if you are up for that, would be cool to change it. but i am fine keeping it if you don't have the time to invest into it.

I'll gladly do this, but if its fine for you I'd rather do that in a separate PR.

[dbu]

yeah agree with separate merge requests.

thanks!

[Spea]

in #48 , we had the idea to make attributes optional and not require the library anymore. then we would have to change the attribute parser to not attempt to read annotations if the library is not available. if you are up for that, would be cool to change it. but i am fine keeping it if you don't have the time to invest into it.

I'll gladly do this, but if its fine for you I'd rather do that in a separate PR.

@dbu I was thinking about this a bit more, and I wonder if we can actually do this, since there is still the PhpTypeParser that takes care of checking the types.

[dbu]

oh, you are very right. and i don't see us dropping the php type annotations anytime soon. afaik there is still no other way to e.g. do typed arrays.

then i think we don't need to do anything more on that for now.

from my point of view, this would be ready to tag a release. should i go for it or did you want to do something else before i tag?

[Spea]

from my point of view, this would be ready to tag a release. should i go for it or did you want to do something else before i tag?

Fine for me. I'm still working on the discriminator support, but that might take a bit longer. Though nothing is pressuring us since the serializer also has to go to a new major version when using the metadataparser 2.x, correct?

Anyway, I think its fine to do a release and we add discriminator support in 2.1 then.