Multiple alarms for one attendee on an event

[chibenwa]

GIVEN bob has a "take the train" event
AND an alarm 1 day before (print ticket)
AND an alarm 1 hour before (go to train session)
AND an alarm 5 minute before (drop coffee and enter the train)
UPON the 3 right times
THEN bob is notified

Ensure that our alarm system handle multiple alarms for a single attendee

Explicitly test it.

[vttranlina]

Currently, the AlarmInstantFactory.java#L108API supports multiple alarms.

AlarmInstantFactory calculates the nearest valid alarm time, and this is reflected in the following test cases:

• shouldPickEarliestValidAlarmAmongMultiple (implemented)
• shouldPickEarliestValidAlarmWhenEarlierOneExpired

However, the scheduler does not yet handle this for single events.

To address this, we need to modify the method com.linagora.calendar.scheduling.AlarmTriggerService#cleanup.

Current

alarmEventDAO.delete(alarmEvent.eventUid(), alarmEvent.recipient());

Suggestion

Optional<AlarmInstant> nextAlarm = alarmInstantFactory.computeNextAlarmInstant(...);

if (nextAlarm.isEmpty()) {
    alarmEventDAO.delete(alarmEvent.eventUid(), alarmEvent.recipient());
} else {
    alarmEventDAO.update(...);
}

This flow is similar to how we've handled recurrence events.

Lastly, TODO integration tests should also be added to validate this feature.