Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor add_nested to join_nested #120

Open
3 of 4 tasks
hombit opened this issue Jul 8, 2024 · 1 comment
Open
3 of 4 tasks

Refactor add_nested to join_nested #120

hombit opened this issue Jul 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Collaborator

hombit commented Jul 8, 2024

Currently, the only supported way to add nested columns is by packing them by index and assigning them to NestedFrame with the same index values. However, as was found during the LSDB integration (astronomy-commons/lsdb#368, astronomy-commons/lsdb#367), it is important to pack by the value column instead of index.

Additionally, it would be nice to make the interface closer to pandas’ join by supporting on and how arguments.

The following steps are proposed:

@hombit hombit added the enhancement New feature or request label Jul 8, 2024
@wilsonbb wilsonbb assigned wilsonbb and unassigned wilsonbb Jul 9, 2024
@wilsonbb wilsonbb changed the title Refactor add_nested to nested_join Refactor add_nested to join_nested Jul 9, 2024
@hombit
Copy link
Collaborator Author

hombit commented Nov 6, 2024

Everything but renaming is implemented in v0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants